From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1557122-1518187856-2-16353643939452371358 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1518187856; b=DmBCL38+eZJ8sqKxC4ZfTssVmdlLfriqrXOZhhtXcvMEdQo q3eZm3d687ZOFbBXeGZ0M7W4AlNSXTA/zm12T6opXyatxRhdG1rcVMo2IDb48/wX MPxQbSHc/NTGUDfxiwJ88MbUMyW8alfVHAzT1lbwk0Vis+seFIqdfeP0MG39EkUf OI1GXpuio6r5xTMgwdL+4VfDrpdB4fOlnk4gLODLch5nRVeoXOzSpRADItLD49hw meHoecAOnD2pW+yA224WnCSMlj9yu7JxbKCkPlJ2nFqVWBbnG+2P4/NOKmT7vfHj Wgl6IeDl9YTuJq+4V2gOhibYg9J6Q7kSmY11xxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id:sender :list-id; s=arctest; t=1518187856; bh=CAwmHSgkPC7Pg7Bqya0HQQBmRd obxgwmOriY2yEmDj8=; b=s2L11zZoh+c45SiCWJMBnbcGDF1Erp2PxAW9weL5aE 1AntWNoaC3wxWhdesQoNIbQJkwO52KnmqrDvXv8sxMIg5oFAgMZZhG5JpJVQQw+5 K8Mxldn+je1NQDc3rUXr2ezOxphO0R13IoDGtF+WTyD0ENybL5qdKL0WgQ48j4No zzpWoZBm1MNUnSODw+oS4FOQeYVphqp/88usH53gLddsiY2Iu2TkMhgnvAJk3FUH Y6gUaX4Pc7g9iiO5TpHrlb90yr7JtcI0ikS7QpH8ctst/Ntqsmdrd9XxAbh/UExH K2t82S/XULdWyX2IdLGJTKzQuOhPgV1ZlxAnRZzrXZBQ== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=kernel.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=orgdomain_pass; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=kernel.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751092AbeBIOul (ORCPT ); Fri, 9 Feb 2018 09:50:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:39316 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbeBIOuk (ORCPT ); Fri, 9 Feb 2018 09:50:40 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4FB421789 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=kbingham@kernel.org From: Kieran Bingham To: Laurent Pinchart , mchehab@kernel.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kieran Bingham Cc: Kieran Bingham , "Stable v4.14+" Subject: [PATCH] v4l: vsp1: Fix header display list status check in continuous mode Date: Fri, 9 Feb 2018 14:50:34 +0000 Message-Id: <1518187834-21267-1-git-send-email-kbingham@kernel.org> X-Mailer: git-send-email 2.7.4 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Kieran Bingham To allow dual pipelines utilising two WPF entities when available, the VSP was updated to support header-mode display list in continuous pipelines. A small bug in the status check of the command register causes the second pipeline to be directly afflicted by the running of the first; appearing as a perceived performance issue with stuttering display. Fix the vsp1_dl_list_hw_update_pending() call to ensure that the read comparison corresponds to the correct pipeline. Fixes: eaf4bfad6ad8 ("v4l: vsp1: Add support for header display lists in continuous mode") Cc: "Stable v4.14+" Reviewed-by: Laurent Pinchart Signed-off-by: Kieran Bingham --- drivers/media/platform/vsp1/vsp1_dl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/drivers/media/platform/vsp1/vsp1_dl.c index 8cd03ee45f79..34b5ed2592f8 100644 --- a/drivers/media/platform/vsp1/vsp1_dl.c +++ b/drivers/media/platform/vsp1/vsp1_dl.c @@ -509,7 +509,8 @@ static bool vsp1_dl_list_hw_update_pending(struct vsp1_dl_manager *dlm) return !!(vsp1_read(vsp1, VI6_DL_BODY_SIZE) & VI6_DL_BODY_SIZE_UPD); else - return !!(vsp1_read(vsp1, VI6_CMD(dlm->index) & VI6_CMD_UPDHDR)); + return !!(vsp1_read(vsp1, VI6_CMD(dlm->index)) + & VI6_CMD_UPDHDR); } static bool vsp1_dl_hw_active(struct vsp1_dl_manager *dlm) -- 2.7.4