mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jia Zhang <zhang.jia@linux.alibaba.com>
To: tglx@linutronix.de, jolsa@redhat.com, mingo@redhat.com, hpa@zytor.com
Cc: x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally
Date: Mon, 12 Feb 2018 22:44:54 +0800	[thread overview]
Message-ID: <1518446694-21124-3-git-send-email-zhang.jia@linux.alibaba.com> (raw)
In-Reply-To: <1518446694-21124-1-git-send-email-zhang.jia@linux.alibaba.com>

The vsyscall page should be visible only if
vsyscall=emulate/native when dumping /proc/kcore.

Signed-off-by: Jia Zhang <zhang.jia@linux.alibaba.com>
Reviewed-by: Jiri Olsa <jolsa@kernel.org>
---
 arch/x86/mm/init_64.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/mm/init_64.c b/arch/x86/mm/init_64.c
index 14cd7f8..cbd6ea4 100644
--- a/arch/x86/mm/init_64.c
+++ b/arch/x86/mm/init_64.c
@@ -1193,8 +1193,10 @@ void __init mem_init(void)
 	register_page_bootmem_info();
 
 	/* Register memory areas for /proc/kcore */
-	kclist_add(&kcore_vsyscall, (void *)VSYSCALL_ADDR,
-		   PAGE_SIZE, KCORE_USER);
+	if (get_gate_vma(&init_mm)) {
+		kclist_add(&kcore_vsyscall, (void *)VSYSCALL_ADDR,
+			   PAGE_SIZE, KCORE_USER);
+	}
 
 	mem_init_print_info(NULL);
 }
-- 
1.8.3.1

  parent reply	other threads:[~2018-02-12 14:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 14:44 [PATCH v2 0/2] /proc/kcore: Fix SMAP violation when dumping vsyscall user page Jia Zhang
2018-02-12 14:44 ` [PATCH 1/2] " Jia Zhang
2018-02-13  9:07   ` [tip:x86/urgent] vfs/proc/kcore, x86/mm/kcore: Fix SMAP fault " tip-bot for Jia Zhang
2018-02-12 14:44 ` Jia Zhang [this message]
2018-02-13  9:08   ` [tip:x86/urgent] x86/mm/kcore: Add vsyscall page to /proc/kcore conditionally tip-bot for Jia Zhang
  -- strict thread matches above, loose matches on Subject: below --
2018-01-30  6:42 [PATCH 1/2] /proc/kcore: Fix SMAP violation when dumping vsyscall user page Jia Zhang
2018-01-30  6:42 ` [PATCH 2/2] x86/mm/64: Add vsyscall page to /proc/kcore conditionally Jia Zhang
2018-02-05  9:26   ` Jiri Olsa
2018-02-09  1:08     ` Jia Zhang
2018-02-12  9:59       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1518446694-21124-3-git-send-email-zhang.jia@linux.alibaba.com \
    --to=zhang.jia@linux.alibaba.com \
    --cc=hpa@zytor.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®