From: "David S. Miller" <davem@redhat.com>
To: David Ford <david@blue-labs.org>
Cc: Alan Cox <laughing@shared-source.org>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.6-ac4
Date: Sun, 15 Jul 2001 17:49:28 -0700 (PDT) [thread overview]
Message-ID: <15186.14872.117342.143216@pizda.ninka.net> (raw)
In-Reply-To: <3B52335C.7040005@blue-labs.org>
In-Reply-To: <20010716004933.A18030@lightning.swansea.linux.org.uk> <3B52335C.7040005@blue-labs.org>
David Ford writes:
> Have you reviewed the patch I posted yesterday regarding net_dev_init()
> and double lock in sch_teql.c?
>
> net_dev_init() is originally called in genhd.c, I don't see as it's
> necessary to call it again.
It is called early if a device initialization occurs before
the genhd.c call, which is entirely possibly particularly on s390.
Your change would break s390* ports.
I sent the correct fix to Linus last night, which is:
--- net/core/dev.c.~1~ Mon Jul 9 22:19:33 2001
+++ net/core/dev.c Sat Jul 14 17:25:51 2001
@@ -2654,10 +2654,6 @@
if (!dev_boot_phase)
return 0;
-#ifdef CONFIG_NET_SCHED
- pktsched_init();
-#endif
-
#ifdef CONFIG_NET_DIVERT
dv_init();
#endif /* CONFIG_NET_DIVERT */
@@ -2771,6 +2767,10 @@
dst_init();
dev_mcast_init();
+
+#ifdef CONFIG_NET_SCHED
+ pktsched_init();
+#endif
/*
* Initialise network devices
next prev parent reply other threads:[~2001-07-16 0:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-15 23:49 Alan Cox
2001-07-16 0:20 ` David Ford
2001-07-16 0:49 ` David S. Miller [this message]
2001-07-16 2:02 ` Udo A. Steinberg
2001-07-16 2:13 ` Udo A. Steinberg
2001-07-16 11:16 ` Alan Cox
2001-07-16 11:58 Mikael Pettersson
2001-07-16 12:24 ` Xavier Bestel
2001-07-16 12:45 ` Alan Cox
2001-07-16 16:18 ` Xavier Bestel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15186.14872.117342.143216@pizda.ninka.net \
--to=davem@redhat.com \
--cc=david@blue-labs.org \
--cc=laughing@shared-source.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®