From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756663AbeBOXNs (ORCPT ); Thu, 15 Feb 2018 18:13:48 -0500 Received: from mail-pg0-f65.google.com ([74.125.83.65]:35439 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756495AbeBOXNr (ORCPT ); Thu, 15 Feb 2018 18:13:47 -0500 X-Google-Smtp-Source: AH8x224Zl9r28/Abuu9WvE5PEXAZIiTyjMa6IcTKLJS3M/8gXkhGyFmfE28QzQTpNilA5ZMKTg20Hw== From: "James A. MacInnes" To: sre@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "James A. MacInnes" Subject: [PATCH] power:sbs-manager: Fix double shift of select reg Date: Thu, 15 Feb 2018 15:13:33 -0800 Message-Id: <1518736413-4797-1-git-send-email-james.a.macinnes@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 1 << BIT() causes double shift when the macro is unwrapped removed extra "1 <<" --- drivers/power/supply/sbs-manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sbs-manager.c index ccb4217..cb6e8f6 100644 --- a/drivers/power/supply/sbs-manager.c +++ b/drivers/power/supply/sbs-manager.c @@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_core *muxc, u32 chan) return ret; /* chan goes from 1 ... 4 */ - reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan); + reg = BIT(SBSM_SMB_BAT_OFFSET + chan); ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg); if (ret) dev_err(dev, "Failed to select channel %i\n", chan); -- 2.7.4