From: Joe Perches <joe@perches.com>
To: Greg KH <gregkh@linuxfoundation.org>, Yash Omer <yashomer0007@gmail.com>
Cc: devel@driverdev.osuosl.org,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] Staging: wlan-ng: Fix Alignment should match open paranthesis in prism2mgmt.c
Date: Fri, 16 Feb 2018 08:46:16 -0800 [thread overview]
Message-ID: <1518799576.13169.10.camel@perches.com> (raw)
In-Reply-To: <20180216143606.GA28713@kroah.com>
On Fri, 2018-02-16 at 15:36 +0100, Greg KH wrote:
> On Fri, Feb 16, 2018 at 12:18:36AM +0530, Yash Omer wrote:
> > This is patch fixes up a matching paranthesis alignment issue found by checkpatch.pl script.
[]
> > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
[]
> > @@ -264,8 +264,8 @@ int prism2mgmt_scan(struct wlandevice *wlandev, void *msgp)
> > goto exit;
> > }
> > /* ibss options */
> > - result = hfa384x_drvr_setconfig16(hw,
> > - HFA384x_RID_CREATEIBSS,
> > + result = hfa384x_drvr_setconfig16
> > + (hw, HFA384x_RID_CREATEIBSS,
>
> The original code is just fine, why is checkpatch complaining about
> this?
lack of argument alignment to parentheses.
Maybe wlan-ng should be marked obsolete in MAINTAINERS.
prev parent reply other threads:[~2018-02-16 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 18:48 Yash Omer
2018-02-16 14:36 ` Greg KH
2018-02-16 16:46 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1518799576.13169.10.camel@perches.com \
--to=joe@perches.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yashomer0007@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome