mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
To: "jcm@jonmasters.org" <jcm@jonmasters.org>,
	"rjw@rjwysocki.net" <rjw@rjwysocki.net>,
	"Wang, Dongsheng" <dongsheng.wang@hxt-semitech.com>,
	"guohanjun@huawei.com" <guohanjun@huawei.com>
Cc: "lenb@kernel.org" <lenb@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Zheng, Joey" <yu.zheng@hxt-semitech.com>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"Jiang, Yutang2" <yutang2.jiang@hxt-semitech.com>
Subject: Re: [PATCH v3] ACPI / tables: Add IORT to injectable table list
Date: Tue, 20 Feb 2018 02:52:08 +0000	[thread overview]
Message-ID: <1519095127.2772.10.camel@hxt-semitech.com> (raw)
In-Reply-To: <669340a4-e748-07f4-51d5-bf0566cd75b8@jonmasters.org>

Hi, Jon,

On Mon, 2018-02-19 at 14:13 -0500, Jon Masters wrote:
> On 02/02/2018 07:12 AM, Wang, Dongsheng wrote:
> > 
> > Hey, Hanjun,
> > 
> > On 2018/2/2 19:54:24, "Hanjun Guo" <guohanjun@huawei.com> wrote:
> > 
> > > 
> > > On 2018/2/2 18:25, Yang Shunyong wrote:
> > > > 
> > > > Loading IORT table from initrd is used to fix firmware IORT
> > > > defects.
> > > I don't think this fix "firmware defects", it just for debug
> > > purpose,
> > > we will not use that for production purpose, right? I think above
> > > line
> > > can be removed.
> > > 
> > I thinks the upgrade feature not only for debug. Here's an
> > important
> > way to fix bugs that come from the firmware.
> > 
> > Documentation/acpi/initrd_table_override.txt
> I think we should message that this is for debug/development use.
> Ultimately, it's not the way to address firmware problems. Firmware
> needs to address that by shipping the correct(ed) tables :)

Thanks for your feedback.
According to following description in
Documentation/acpi/initrd_table_override.txt
"Complain to your platform/BIOS vendor if you find a bug which is so
severe that a workaround is not accepted in the Linux kernel. And this
facility allows you to upgrade the buggy tables before your
platform/BIOS vendor releases an upgraded BIOS binary."

I have changed the commit message to "Loading IORT table from initrd
can be used to fix severe firmware
IORT defects temporarily before platform/BIOS vendor releases an
upgraded BIOS binary..." in v4.

Detail Link is here,
https://patchwork.kernel.org/patch/10202391/

Thanks.
Shunyong.

      reply	other threads:[~2018-02-20  2:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-02 10:25 Yang Shunyong
2018-02-02 11:54 ` Hanjun Guo
2018-02-02 12:12   ` Wang, Dongsheng
2018-02-19 19:13     ` Jon Masters
2018-02-20  2:52       ` Yang, Shunyong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519095127.2772.10.camel@hxt-semitech.com \
    --to=shunyong.yang@hxt-semitech.com \
    --cc=dongsheng.wang@hxt-semitech.com \
    --cc=guohanjun@huawei.com \
    --cc=jcm@jonmasters.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=yu.zheng@hxt-semitech.com \
    --cc=yutang2.jiang@hxt-semitech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®