From: John Garry <john.garry@huawei.com>
To: <andriy.shevchenko@linux.intel.com>, <gregkh@linuxfoundation.org>,
<slaby@suse.com>, <p.zabel@pengutronix.de>, <heiko@sntech.de>,
<ed.blake@sondrel.com>, <jhogan@kernel.org>
Cc: <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linuxarm@huawei.com>
Subject: [RFC PATCH 1/2] serial: 8250_dw: add IO space support
Date: Fri, 23 Feb 2018 02:42:02 +0800 [thread overview]
Message-ID: <1519324923-196857-2-git-send-email-john.garry@huawei.com> (raw)
In-Reply-To: <1519324923-196857-1-git-send-email-john.garry@huawei.com>
The current 8250_dw driver only supports MEM iotype. It is desired
to have a platform device-based 8250 UART driver for ACPI FW
with IO port iotype, so update the driver to support this.
Note: a solution needs to be found for autconfig
using MEM accessors only.
Signed-off-by: John Garry <john.garry@huawei.com>
---
drivers/tty/serial/8250/8250_dw.c | 25 +++++++++++++++++--------
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index cd1b94a..28fbc8f 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -405,7 +405,7 @@ static void dw8250_setup_port(struct uart_port *p)
static int dw8250_probe(struct platform_device *pdev)
{
struct uart_8250_port uart = {};
- struct resource *regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+ struct resource *regs;
int irq = platform_get_irq(pdev, 0);
struct uart_port *p = &uart.port;
struct device *dev = &pdev->dev;
@@ -413,6 +413,9 @@ static int dw8250_probe(struct platform_device *pdev)
int err;
u32 val;
+ regs = platform_get_resource(pdev, IORESOURCE_MEM, 0) ?:
+ platform_get_resource(pdev, IORESOURCE_IO, 0);
+
if (!regs) {
dev_err(dev, "no registers defined\n");
return -EINVAL;
@@ -425,22 +428,28 @@ static int dw8250_probe(struct platform_device *pdev)
}
spin_lock_init(&p->lock);
- p->mapbase = regs->start;
p->irq = irq;
p->handle_irq = dw8250_handle_irq;
p->pm = dw8250_do_pm;
p->type = PORT_8250;
p->flags = UPF_SHARE_IRQ | UPF_FIXED_PORT;
p->dev = dev;
- p->iotype = UPIO_MEM;
- p->serial_in = dw8250_serial_in;
- p->serial_out = dw8250_serial_out;
p->set_ldisc = dw8250_set_ldisc;
p->set_termios = dw8250_set_termios;
- p->membase = devm_ioremap(dev, regs->start, resource_size(regs));
- if (!p->membase)
- return -ENOMEM;
+ if ((regs->flags & IORESOURCE_TYPE_BITS) == IORESOURCE_MEM) {
+ p->mapbase = regs->start;
+ p->membase = devm_ioremap(dev, regs->start,
+ resource_size(regs));
+ if (!p->membase)
+ return -ENOMEM;
+ p->iotype = UPIO_MEM;
+ p->serial_in = dw8250_serial_in;
+ p->serial_out = dw8250_serial_out;
+ } else {
+ p->iobase = regs->start;
+ p->iotype = UPIO_PORT;
+ }
data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL);
if (!data)
--
1.9.1
next prev parent reply other threads:[~2018-02-22 17:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-22 18:42 [RFC PATCH 0/2] serial: 8250_dw: IO space + polling mode support John Garry
2018-02-22 18:42 ` John Garry [this message]
2018-02-22 18:42 ` [RFC PATCH 2/2] serial: 8250_dw: support polling mode John Garry
2018-02-23 17:35 ` Andy Shevchenko
2018-02-26 10:54 ` John Garry
2018-02-23 10:30 ` [RFC PATCH 0/2] serial: 8250_dw: IO space + polling mode support Andy Shevchenko
2018-02-23 11:02 ` John Garry
2018-02-23 17:31 ` Andy Shevchenko
2018-02-26 9:33 ` John Garry
2018-02-26 9:53 ` Andy Shevchenko
2018-02-26 10:45 ` John Garry
2018-02-26 11:28 ` Andy Shevchenko
2018-02-26 11:56 ` John Garry
2018-02-26 12:21 ` Andy Shevchenko
2018-02-26 12:27 ` Andy Shevchenko
2018-02-26 13:15 ` John Garry
2018-02-26 15:02 ` Andy Shevchenko
2018-02-26 15:07 ` John Garry
2018-04-12 16:31 ` John Garry
2018-02-26 12:37 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1519324923-196857-2-git-send-email-john.garry@huawei.com \
--to=john.garry@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ed.blake@sondrel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=p.zabel@pengutronix.de \
--cc=slaby@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®