mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: mingo@kernel.org, acme@kernel.org
Cc: linux-kernel@vger.kernel.org, Kan Liang <Kan.liang@intel.com>
Subject: [PATCH] perf top: Fix annoying fallback message on older kernel
Date: Mon, 26 Feb 2018 10:17:10 -0800	[thread overview]
Message-ID: <1519669030-176549-1-git-send-email-kan.liang@intel.com> (raw)

From: Kan Liang <Kan.liang@intel.com>

On older (v4.4) kernels, the annoying fallback message can be observed
in 'perf top'.

The 'perf top' has been changed to overwrite mode since
'commit ebebbf082357 ("perf top: Switch default mode to overwrite mode")'
For the older kernels which don't have overwrite mode support, the 'perf
top' will fall back to non-overwrite mode and print out the fallback
message by ui__warning, which needs user's input to close.

The fallback message is not critical message for end users. Turning it
to debug message which is printed when running with -vv.

Fixes: ebebbf082357 ("perf top: Switch default mode to overwrite mode")
Reported-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Kan Liang <Kan.liang@intel.com>
---
 tools/perf/builtin-top.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c
index b7c823b..35ac016 100644
--- a/tools/perf/builtin-top.c
+++ b/tools/perf/builtin-top.c
@@ -991,7 +991,7 @@ static int perf_top_overwrite_fallback(struct perf_top *top,
 	evlist__for_each_entry(evlist, counter)
 		counter->attr.write_backward = false;
 	opts->overwrite = false;
-	ui__warning("fall back to non-overwrite mode\n");
+	pr_debug2("fall back to non-overwrite mode\n");
 	return 1;
 }
 
-- 
2.7.4

             reply	other threads:[~2018-02-26 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-26 18:17 kan.liang [this message]
2018-02-26 19:20 ` Arnaldo Carvalho de Melo
2018-02-27  6:53 ` Ingo Molnar
2018-03-06  6:42 ` [tip:perf/core] perf top: Fix annoying fallback message on older kernels tip-bot for Kan Liang
2018-03-07  8:25 ` [tip:perf/urgent] " tip-bot for Kan Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1519669030-176549-1-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=acme@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®