From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cstnet.cn (smtp25.cstnet.cn [159.226.251.25]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CCDE3C3BE2; Tue, 28 Apr 2026 15:53:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.25 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777391643; cv=none; b=XyeAxrxkOnSIQt01okN1eVv2HIMcrxftBJ3b4qndU5BKs1pvwBJ5kuSvwW5KfMqY4RzjQ1DTpWsPZBzvh+CdZwll8wF8EvOOuFGNG0MOLx6DYQrFmkEy/sWOTvRF8UPPI+EZlGDh0tnzPX6UoRegVj6QD8ALhzA2MapsAVOeT5g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777391643; c=relaxed/simple; bh=K3+V6m0v+TBLOu1erk2jlx7zyg8kD8fYUb6F3jMhkps=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BIXKq8grc+AQs0AA910zTFKum0vSS0CRPMzI1W/AYhF021OPzgWo1PUoQRibSbosZ2e/dcz59aTGiX+d0XZwQ588psCKOr3CpgS39RJsQtPnz4UZkXCSVlW7uUYifmQK3O58qmaMYhMQWCyhBgkUD8dVPvMctjmSfoVqXnuoTyk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn; spf=pass smtp.mailfrom=iscas.ac.cn; arc=none smtp.client-ip=159.226.251.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=iscas.ac.cn Received: from edelgard.fodlan.icenowy.me (unknown [112.94.102.122]) by APP-05 (Coremail) with SMTP id zQCowAB3CQ3o1_BpzKzWDg--.462S2; Tue, 28 Apr 2026 23:53:12 +0800 (CST) Message-ID: <151c1c1d52fce8c3b1dac3a919be3086ce3426df.camel@iscas.ac.cn> Subject: Re: [PATCH] drm/panel: himax-hx83102: restore MODE_LPM after sending disable cmds From: Icenowy Zheng To: Doug Anderson Cc: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Cong Yang , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Date: Tue, 28 Apr 2026 23:53:11 +0800 In-Reply-To: References: <20260425165751.1716569-1-zhengxingda@iscas.ac.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:zQCowAB3CQ3o1_BpzKzWDg--.462S2 X-Coremail-Antispam: 1UD129KBjvJXoW7uw17GF1DZr15trWxArW5KFg_yoW8Cw1kpF W7tFy2kaykJr4IvFn2vw4YvFW7tr43AFWY9rn5K348Z398uF1fCayxtryUuFyUXr4kCw1a vFs2qFy3Xa1vyFUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvvb7Iv0xC_tr1lb4IE77IF4wAFF20E14v26r4j6ryUM7CY07I2 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMc vjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwACI402YVCY1x02628vn2kIc2xKxwCY 1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr1j6F4UJbIYCTnIWIevJa73Uj IFyTuYvjxU2wIDUUUUU X-CM-SenderInfo: x2kh0wp0lqwv3d6l2u1dvotugofq/ =E5=9C=A8 2026-04-28=E4=BA=8C=E7=9A=84 08:48 -0700=EF=BC=8CDoug Anderson=E5= =86=99=E9=81=93=EF=BC=9A > Hi, >=20 > On Mon, Apr 27, 2026 at 10:49=E2=80=AFPM Icenowy Zheng > wrote: > >=20 > > =E5=9C=A8 2026-04-27=E4=B8=80=E7=9A=84 11:24 -0700=EF=BC=8CDoug Anderso= n=E5=86=99=E9=81=93=EF=BC=9A > > > Hi, > > >=20 > > > On Sat, Apr 25, 2026 at 9:58=E2=80=AFAM Icenowy Zheng > > > wrote: > > > >=20 > > > > When preparing the panel, it seems that it always expects > > > > commands > > > > to be > > > > transferred in LP mode. However, the disable function removes > > > > the > > > > MIPI_DSI_MODE_LPM flag, and no other function re-adds it. > > > >=20 > > > > As the unprepare function contains no DSI commands, re-adding > > > > the > > > > flag > > > > just after disabling the panel should be safe. Add the code re- > > > > adding > > > > the flag after the two commands for disabling the panel are > > > > sent. > > > >=20 > > > > This fixes screen unblanking (after blanking once) on > > > > mt8188-geralt-ciri-sku1 device. > > > >=20 > > > > Cc: stable@vger.kernel.org=C2=A0# 6.11+ > > > > Fixes: 0ef94554dc40 ("drm/panel: himax-hx83102: Break out as > > > > separate driver") > > >=20 > > > This "Fixes" looks wrong. The bug was still there even before the > > > driver was broken out. ...and it looks like the driver that this > > > was > > > broken out of (panel-boe-tv101wum-nl6.c) still has the same bug? > >=20 > > Yes, but I think the fix shouldn't be propagated to the other > > driver > > because of the same reason with breaking out the original driver. >=20 > ...but doesn't all the same logic apply to the other driver? Nothing > ever adds MIPI_DSI_MODE_LPM back in. >=20 > Even if you don't fix the other driver yourself right now, the proper > "Fixes" tag is when the problem was introduced, not when the driver > forked out. I think the Fixes tag should point to where the driver is forked out, and if I'm going to send a patch for panel-boe-tv101wum-nl6, it will has a Fixes tag pointing to the further commit affecting that driver. Thanks, Icenowy >=20 > -Doug