From: "David S. Miller" <davem@redhat.com>
To: Roberto Arcomano <berto@fatamorgana.com>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] net/ipv4/arp.c, kernel 2.4.6 - PROXY_ARP bug on shaper device
Date: Sat, 28 Jul 2001 04:43:12 -0700 (PDT) [thread overview]
Message-ID: <15202.42320.389679.847561@pizda.ninka.net> (raw)
In-Reply-To: <01072812012201.01311@berto.casa.it>
In-Reply-To: <01072812012201.01311@berto.casa.it>
Roberto Arcomano writes:
> Solution: The patch investigates about the shaper device
> (it compares string with "shaper"): if yes, we
> search the real interface attached to shaper
> (we read value of priv->dev) and we use that to
> make the classic proxy arp devices compare.
>
> Problems: The patch uses routine "strncmp" which is not the
> best thing (I guess).
This is gross, make a device flag and have shaper set that
flag during shaper device init, then have ARP test it.
Make the name of the flag reflect what the attribute is that shaper
has (and potentially other devices could have) which makes this ARP
special case necessary. Ie. don't name the flag NETIF_F_SHAPER :-)
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~2001-07-28 11:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-28 10:01 Roberto Arcomano
2001-07-28 11:43 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15202.42320.389679.847561@pizda.ninka.net \
--to=davem@redhat.com \
--cc=berto@fatamorgana.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®