From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757959AbcK3OpR (ORCPT <rfc822;w@1wt.eu>);
        Wed, 30 Nov 2016 09:45:17 -0500
Received: from mout.kundenserver.de ([217.72.192.73]:62942 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754198AbcK3OpJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Nov 2016 09:45:09 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Vladimir Zapolskiy <vz@mleia.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        "David S. Miller" <davem@davemloft.net>,
        Marcin Wojtas <mw@semihalf.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: sram: remove useless #ifdef
Date: Wed, 30 Nov 2016 15:44:55 +0100
Message-ID: <15207778.B3o1gTucM7@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <63d62ef3-66dc-bca5-fb12-a14dd1ad324d@mleia.com>
References: <20161122143103.1835294-1-arnd@arndb.de> <63d62ef3-66dc-bca5-fb12-a14dd1ad324d@mleia.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:yXL8R4p8cLiy4VhsY/hYJIEHrPItS2oWOMk8CqabsGsauApkgQI
 urhGtlT2PvJfYtQVuRhZbpYL/1FEqKqRVgBMHG5sVela2rrTkzAfT9doEBsC7Jk70aSyL4H
 uPHcThtrQinr3XicsDYGlzW8rJnP8waEF0ZZHgvo6nnKoWULvtY6yh60S1O/tF4hTj6TPZK
 7EqnYbrNjnkG1MgErmwaQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:4HSjZkJaL0A=:tW+Cnvn97YAPKxJDCCR1P3
 P72NscRxnHV/awkiV5MOi/+O6YmJglB2lx4HNeOBdGGNGwiDEhgTeYYD4FtukalK1iCSlObFr
 1LCIBxmCPUG8sGkaiWr9qLSV63ju1/ZRBLI0vRgsx7IHdCWIPJRb8mjpj1xVxNhtf+RVy7Wm/
 oM4gmQQLFleWtCP2eLj3vnKOnTB0n0vJ7C0jkH5RSg4ctcgtXF9lrVAZnI3U2CtLdhIAE5KW9
 wdw67GNTd+Rb7PIbBb5sNAFf562UxPv4igxi1hLtu2H7WWQTkRkWBjloPt2Tc1dD46bV9WdLD
 QPlSTmvZ0kCGt6/JDcH2aZ/p9JUa7go5hRg1eIf6556tcOpF5Kog+hj7cgZUY0QywNsSXJeV5
 pLeCSYrSEi+/nbHeUAkDD5OAEASfQXt4f8nAoFQY8euizTsfOg7WqTMe8GWbD832NOxxgDwLy
 TrhqgrL7q7FXIlG+5QKvtjHXbnYZngEr5vELISG9oqgHM9WFS+FyiuxQIXl5iDK1WSjKM847n
 5ogDqVqcPsGLeOjd7+N4ZgwO/9eMY0O0LNHb6TB3n2+gS4/AR/fNSaUwVPremNKuFq/9g9WiC
 ihD0Jv/1aGSk/49cjpIuiI2lCrXMiQRchJCKhTxhD/CccYgnyLiXwUeqoM5wRJXC5++F+RFkw
 p+6CFTC01VL2ez5rnGI6nhJs9ayaE8lnXJz8A8bsBZbgPHlIzvqSf7wrR+TYTn2MPS4P+3mtS
 NZ3my+GYqsg/zZ/H
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday, November 22, 2016 7:47:52 PM CET Vladimir Zapolskiy wrote:
> 
> On 11/22/2016 04:30 PM, Arnd Bergmann wrote:
> > A recent patch added a new function that is now unused whenever
> > CONFIG_OF is disabled:
> >
> > drivers/misc/sram.c:342:12: error: 'atmel_securam_wait' defined but not used [-Werror=unused-function]
> >
> > There is actually no reason for the #ifdef, because the driver
> > currently cannot be used in a meaningful way without CONFIG_OF,
> > and there is no compile-time dependency.
> >
> > Removing that #ifdef and the respective of_match_ptr() avoids the
> > warning and simplifies the driver slightly.
> >
> > Fixes: 2ae2e28852f2 ("misc: sram: add Atmel securam support")
> 
> I can not find the referenced commit on Torvald's branch,
> won't it be rebased and get a changed commit hash after merge?
> 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> 
> The change itself is good, thank you for the fix.
> 
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> 

Applied on arm-soc/next/drivers now, thanks.

	Arnd