From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932388AbeCMRrU (ORCPT ); Tue, 13 Mar 2018 13:47:20 -0400 Received: from mga03.intel.com ([134.134.136.65]:22232 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752263AbeCMRrS (ORCPT ); Tue, 13 Mar 2018 13:47:18 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,465,1515484800"; d="scan'208";a="24188013" Message-ID: <1520963237.15766.216.camel@linux.intel.com> Subject: Re: [PATCH] ACPI / PM: Reduce LPI constraints logging noise From: Srinivas Pandruvada To: "Rafael J. Wysocki" , Linux ACPI Cc: Linux PM , LKML Date: Tue, 13 Mar 2018 10:47:17 -0700 In-Reply-To: <2232544.VHtLQCEKNu@aspire.rjw.lan> References: <2232544.VHtLQCEKNu@aspire.rjw.lan> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.24.6 (3.24.6-1.fc26) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-03-13 at 10:47 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > If a device referred to by ACPI LPI constrains (coming from function > 1 > of the Low Power S0 Idle _DSM interface) is not power-manageable via > ACPI (no _PS0 method and no power resources), the code generating > diagnostic information for the LPI constraints will print a message > about that to the kernel log on every system suspend-resume cycle > (possibly for multiple times). > > That is not very useful and noisy, so modify that code to disregard > the LPI list entries corresponding to the devices that are not power- > manageable after printing that information for them once. > > Signed-off-by: Rafael J. Wysocki Reviewed-by: Srinivas Pandruvada > --- > drivers/acpi/sleep.c | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > Index: linux-pm/drivers/acpi/sleep.c > =================================================================== > --- linux-pm.orig/drivers/acpi/sleep.c > +++ linux-pm/drivers/acpi/sleep.c > @@ -851,23 +852,25 @@ static void lpi_check_constraints(void) > int i; > > for (i = 0; i < lpi_constraints_table_size; ++i) { > + acpi_handle handle = > lpi_constraints_table[i].handle; > struct acpi_device *adev; > > - if > (acpi_bus_get_device(lpi_constraints_table[i].handle, &adev)) > + if (!handle || acpi_bus_get_device(handle, &adev)) > continue; > > - acpi_handle_debug(adev->handle, > + acpi_handle_debug(handle, > "LPI: required min power state:%s current > power state:%s\n", > acpi_power_state_string(lpi_constraints_tabl > e[i].min_dstate), > acpi_power_state_string(adev->power.state)); > > if (!adev->flags.power_manageable) { > - acpi_handle_info(adev->handle, "LPI: Device > not power manageble\n"); > + acpi_handle_info(handle, "LPI: Device not > power manageable\n"); > + lpi_constraints_table[i].handle = NULL; > continue; > } > > if (adev->power.state < > lpi_constraints_table[i].min_dstate) > - acpi_handle_info(adev->handle, > + acpi_handle_info(handle, > "LPI: Constraint not met; min power > state:%s current power state:%s\n", > acpi_power_state_string(lpi_constrai > nts_table[i].min_dstate), > acpi_power_state_string(adev- > >power.state)); >