From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbeCPRzd convert rfc822-to-8bit (ORCPT ); Fri, 16 Mar 2018 13:55:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:32792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbeCPRzb (ORCPT ); Fri, 16 Mar 2018 13:55:31 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 790D5204EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=sboyd@kernel.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Bartosz Golaszewski , David Lechner From: Stephen Boyd In-Reply-To: Cc: linux-clk@vger.kernel.org, linux-devicetree , arm-soc , Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Sekhar Nori , Kevin Hilman , Adam Ford , LKML References: <1519071723-31790-1-git-send-email-david@lechnology.com> <1519071723-31790-11-git-send-email-david@lechnology.com> Message-ID: <152122292977.70929.17084619305591596735@swboyd.mtv.corp.google.com> User-Agent: alot/0.7 Subject: Re: [PATCH v7 10/42] clk: davinci: New driver for davinci PSC clocks Date: Fri, 16 Mar 2018 10:55:29 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Bartosz Golaszewski (2018-02-28 04:38:38) > 2018-02-19 21:21 GMT+01:00 David Lechner : > > I believe there to be two issues: one is with v7 - we need to increase > the clock reference count in davinci_psc_genpd_attach_dev(). > > Second is the error path in the clock framework - we should remove the > destroyed clk_core from the debug list, which is not being done now. > > Why we even need to track the refcount of clk_core is a mistery for me > though. Stephen, Mike? > Which part of the code are we talking about? I see that __clk_core_init() calls clk_debug_register() when ret == 0 and that looks fine. I do wonder why clk_debug_register() even returns a value though because we ignore it.