From: David Howells <dhowells@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com,
syzbot <syzbot+e79818f5c12416aba9de@syzkaller.appspotmail.com>,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [crypto?] general protection fault in cryptd_hash_export
Date: Wed, 14 Jun 2023 13:04:38 +0100 [thread overview]
Message-ID: <1521347.1686744278@warthog.procyon.org.uk> (raw)
In-Reply-To: <ZIhD53a/6Svmn1aS@gondor.apana.org.au>
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> David, the logic for calling hash_alloc_result looks quite different
> from that on whether you do the hash finalisation. I'd suggest that
> you change them to use the same check, and also set use NULL instead
> of ctx->result if you didn't call hash_alloc_result.
I don't fully understand what the upstream hash_sendmsg() is doing. Take this
bit for example:
if (!ctx->more) {
if ((msg->msg_flags & MSG_MORE))
hash_free_result(sk, ctx);
Why is it freeing the old result only if MSG_MORE is now set, but wasn't set
on the last sendmsg()?
David
next prev parent reply other threads:[~2023-06-14 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 9:43 syzbot
2023-06-13 10:24 ` Herbert Xu
2023-06-14 12:04 ` David Howells [this message]
2023-06-14 14:54 ` David Howells
2023-06-14 22:42 ` syzbot
2023-07-25 12:57 ` syzbot
2023-07-25 12:58 ` Aleksandr Nogikh
2023-07-25 15:29 ` David Howells
2023-07-25 16:02 ` syzbot
2023-07-26 13:01 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521347.1686744278@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+e79818f5c12416aba9de@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®