From: Joe Perches <joe@perches.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Andy Whitcroft <apw@canonical.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clang-format: add configuration file
Date: Sun, 18 Mar 2018 11:26:19 -0700 [thread overview]
Message-ID: <1521397579.27411.39.camel@perches.com> (raw)
In-Reply-To: <20180318171632.qfkemw3mwbcukth6@gmail.com>
On Sun, 2018-03-18 at 18:16 +0100, Miguel Ojeda wrote:
> * Uses clang's tooling support behind the scenes to parse and rewrite
> the code. It is not based on ad-hoc regexps.
Did you look at the results of a typical and generally
style conforming
subsystem when reformatted with the new
rules you propose here with
clang-format?
One of the issues with hard-n-fast code formatters like
clang-format is taste.
clang-format doesn't have any so it can't know when _not_
to reformat blocks according to its rules.
Tools like clang-format are generally fine for a first-pass
reformat of non-style compliant code, but are IMO generally
unsuitable for continuous automated use.
next prev parent reply other threads:[~2018-03-18 18:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 17:16 Miguel Ojeda
2018-03-18 18:26 ` Joe Perches [this message]
2018-03-18 18:59 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521397579.27411.39.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®