From: "David S. Miller" <davem@redhat.com>
To: Keith Owens <kaos@ocs.com.au>
Cc: linux-kernel@vger.kernel.org, Mirko Lindner <mlindner@syskonnect.de>
Subject: Re: drivers/net/sk98lin/skproc.c undefined root_dev
Date: Sun, 5 Aug 2001 22:43:42 -0700 (PDT) [thread overview]
Message-ID: <15214.11918.92118.404546@pizda.ninka.net> (raw)
In-Reply-To: <346.997072381@ocs3.ocs-net>
In-Reply-To: <346.997072381@ocs3.ocs-net>
Keith Owens writes:
> drivers/net/sk98lin/skproc.c:extern struct net_device *root_dev
> Defined extern, all other definitions of root_dev are static, except in
> sparc. CONFIG_SK98LIN is not limited to sparc. Either the config is
> wrong or the code in skproc is wrong.
I think two things are wrong here, nice spotting:
1) root_dev in the sk98lin driver needs another name if it is
going to be exported to multiple objects within the driver.
Something like sk98lin_root_dev.
2) It should be non-static in skge.c
I distinctly remember it compiling and working correctly on x86
sometime earlier in the 2.4.x series, so perhaps this brokenness
is recent.
Later,
David S. Miller
davem@redhat.com
prev parent reply other threads:[~2001-08-06 5:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-06 4:33 Keith Owens
2001-08-06 5:43 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15214.11918.92118.404546@pizda.ninka.net \
--to=davem@redhat.com \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@syskonnect.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®