From: Joe Perches <joe@perches.com>
To: Quytelda Kahja <quytelda@tamalin.org>,
gregkh@linuxfoundation.org, wsa@the-dreams.de
Cc: driverdev-devel@linuxdriverproject.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] staging: ks7010: Fix line over 80 characters.
Date: Mon, 19 Mar 2018 23:08:07 -0700 [thread overview]
Message-ID: <1521526087.12047.1.camel@perches.com> (raw)
In-Reply-To: <20180320055815.32651-5-quytelda@tamalin.org>
On Mon, 2018-03-19 at 22:58 -0700, Quytelda Kahja wrote:
> There is no reason for comment describing the BSSID check for loop
> to be spaced so far to the right. Move it above the for loop.
[]
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
[]
> @@ -844,7 +844,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
> ap_info = (struct ap_info_t *)(priv->rxp);
>
> if (priv->scan_ind_count) {
> - for (i = 0; i < priv->aplist.size; i++) { /* bssid check */
> + /* bssid check */
> + for (i = 0; i < priv->aplist.size; i++) {
> if (memcmp(ap_info->bssid,
> priv->aplist.ap[i].bssid, ETH_ALEN) != 0)
this could also use ether_addr_equal
next prev parent reply other threads:[~2018-03-20 6:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 6:26 [PATCH 1/6] staging: ks7010: Factor out repeated code Quytelda Kahja
2018-03-19 18:51 ` Greg KH
2018-03-20 5:58 ` Quytelda Kahja
2018-03-20 5:58 ` [PATCH 2/6] staging: ks7010: Factor out code into helper methods Quytelda Kahja
2018-03-20 5:58 ` [PATCH 3/6] staging: ks7010: Remove unnecessary parentheses Quytelda Kahja
2018-03-22 17:19 ` Greg KH
2018-03-20 5:58 ` [PATCH 4/6] staging: ks7010: Remove unnecessary braces Quytelda Kahja
2018-03-20 5:58 ` [PATCH 5/6] staging: ks7010: Fix line over 80 characters Quytelda Kahja
2018-03-20 6:08 ` Joe Perches [this message]
2018-03-20 5:58 ` [PATCH 6/6] staging: ks7010: Factor out repeated request initialization code Quytelda Kahja
2018-03-22 17:19 ` Greg KH
2018-03-22 17:20 ` [PATCH 1/6] staging: ks7010: Factor out repeated code Greg KH
2018-03-23 5:07 ` [PATCH 1/7] staging: ks7010: Fix line over 80 characters Quytelda Kahja
2018-03-23 5:07 ` [PATCH 2/7] staging: ks7010: Fix lines over 80 characters due to comments Quytelda Kahja
2018-03-23 5:07 ` [PATCH 3/7] staging: ks7010: Factor out common members in request structs Quytelda Kahja
2018-03-23 14:58 ` Greg KH
2018-03-24 6:40 ` [PATCH 1/2] staging: ks7010: Remove trailing "_t" from all structure names Quytelda Kahja
2018-03-24 6:40 ` [PATCH 2/2] staging: ks7010: Fix spelling mistakes Quytelda Kahja
2018-03-28 11:50 ` [PATCH 1/2] staging: ks7010: Remove trailing "_t" from all structure names Greg KH
2018-03-23 5:07 ` [PATCH 4/7] staging: ks7010: Remove duplicate #define's Quytelda Kahja
2018-03-23 5:07 ` [PATCH 5/7] staging: ks7010: Replace memcmp() operation with ether_addr_equal() Quytelda Kahja
2018-03-23 5:07 ` [PATCH 6/7] staging: ks7010: Factor out repeated code for reading IEs Quytelda Kahja
2018-03-23 5:07 ` [PATCH 7/7] staging: ks7010: Remove hostif_infrastructure_set2_request_t Quytelda Kahja
2018-03-16 6:30 [PATCH 2/6] staging: ks7010: Factor out code into helper methods Quytelda Kahja
2018-03-16 6:30 ` [PATCH 5/6] staging: ks7010: Fix line over 80 characters Quytelda Kahja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521526087.12047.1.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quytelda@tamalin.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome