From: Joe Perches <joe@perches.com>
To: Paul McQuade <paulmcquad@gmail.com>
Cc: gregkh@linuxfoundation.org, davem@davemloft.net,
stephen@networkplumber.org, Linyu.Yuan@alcatel-sbell.com.cn,
Larry.Finger@lwfinger.net, keescook@chromium.org,
hdegoede@redhat.com, johannes.berg@intel.com,
colin.king@canonical.com, arvind.yadav.cs@gmail.com,
arnd@arndb.de, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [v2 PATCH 5/5] Staging:rtl8723bs clean spaces
Date: Tue, 20 Mar 2018 13:32:35 -0700 [thread overview]
Message-ID: <1521577955.12047.26.camel@perches.com> (raw)
In-Reply-To: <20180320202622.13339-5-paulmcquad@gmail.com>
On Tue, 2018-03-20 at 20:26 +0000, Paul McQuade wrote:
> Used checkpatch.pl to clean up spaces around if and for statements
> to make it easier to read
Perhaps the commit message can be made clearer.
I think this is technically correct, but it would
be nicer to describe these changes as moving braces
to the more common kernel-style locations.
> diff --git a/drivers/staging/rtl8723bs/os_dep/recv_linux.c b/drivers/staging/rtl8723bs/os_dep/recv_linux.c
[]
> @@ -20,8 +20,7 @@
>
> void rtw_os_free_recvframe(union recv_frame *precvframe)
> {
> - if (precvframe->u.hdr.pkt)
> - {
> + if (precvframe->u.hdr.pkt) {
> dev_kfree_skb_any(precvframe->u.hdr.pkt);/* free skb by driver */
>
> precvframe->u.hdr.pkt = NULL;
prev parent reply other threads:[~2018-03-20 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 20:26 [v2 PATCH 1/5] Staging:rtl8723bs static variables are always 0 Paul McQuade
2018-03-20 20:26 ` [v2 PATCH 2/5] Staging:rtl8723bs clean up spaces Paul McQuade
2018-03-20 20:26 ` [v2 PATCH 3/5] Staging:rtl8723bs Remove unnecessary braces Paul McQuade
2018-03-20 20:26 ` [v2 PATCH 4/5] Staging:rtl8723bs:Add blank line after declaration Paul McQuade
2018-03-20 20:26 ` [v2 PATCH 5/5] Staging:rtl8723bs clean spaces Paul McQuade
2018-03-20 20:32 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521577955.12047.26.camel@perches.com \
--to=joe@perches.com \
--cc=Larry.Finger@lwfinger.net \
--cc=Linyu.Yuan@alcatel-sbell.com.cn \
--cc=arnd@arndb.de \
--cc=arvind.yadav.cs@gmail.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=johannes.berg@intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome