From: "David S. Miller" <davem@redhat.com>
To: Sampsa Ranta <sampsa@netsonic.fi>
Cc: Alan Cox <laughing@shared-source.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.4.7-ac9 (breaks ATM connect)
Date: Thu, 9 Aug 2001 13:30:14 -0700 (PDT) [thread overview]
Message-ID: <15218.62166.839967.47354@pizda.ninka.net> (raw)
In-Reply-To: <Pine.LNX.4.33.0108092225440.31580-100000@nalle.netsonic.fi>
In-Reply-To: <Pine.LNX.4.33.0108092210260.31580-100000@nalle.netsonic.fi> <Pine.LNX.4.33.0108092225440.31580-100000@nalle.netsonic.fi>
Sampsa Ranta writes:
> Pardon me, bugs come in too easy..
>
> - vci != ATM_VCI_ANY && vci >> dev->ci_range.vci_bits))
> + vci != ATM_VCI_ANY && vci >= 1 << dev->ci_range.vci_bits))
>
This is rediculious, why has this expression changed when right
above it is the same thing:
vpi >> dev->ci_range.vpi_bits) || (vci != ATM_VCI_UNSPEC &&
Shouldn't we be changing that "vpi >> dev->ci_range.vpi_bits" boolean
test as well?
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-09 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-07 22:53 Linux 2.4.7-ac9 Alan Cox
2001-08-08 1:55 ` Rik van Riel
2001-08-08 3:32 ` Josh McKinney
2001-08-09 19:24 ` Linux 2.4.7-ac9 (breaks ATM connect) Sampsa Ranta
2001-08-09 19:27 ` Sampsa Ranta
2001-08-09 20:30 ` David S. Miller [this message]
2001-08-09 20:52 ` Chris Friesen
2001-08-09 21:32 Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15218.62166.839967.47354@pizda.ninka.net \
--to=davem@redhat.com \
--cc=laughing@shared-source.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sampsa@netsonic.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®