From: Paul Cercueil <paul@crapouillou.net>
To: James Hogan <jhogan@kernel.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: Fix build with DEBUG_ZBOOT and MACH_JZ4770
Date: Sun, 25 Mar 2018 11:38:27 -0300 [thread overview]
Message-ID: <1521988707.2054.0@smtp.crapouillou.net> (raw)
In-Reply-To: <20180322102606.GE13126@saruman>
Hi,
Le jeu. 22 mars 2018 à 7:26, James Hogan <jhogan@kernel.org> a écrit :
> On Sat, Mar 17, 2018 at 09:11:09PM +0100, Paul Cercueil wrote:
>> Since the UART addresses are the same across all Ingenic SoCs, we
>> just
>> use a #ifdef CONFIG_MACH_INGENIC instead of checking for indifidual
>> Ingenic SoCs.
>
> s/indifidual/individual/
>
>> --- a/arch/mips/boot/compressed/uart-16550.c
>> +++ b/arch/mips/boot/compressed/uart-16550.c
>> @@ -18,9 +18,9 @@
>> #define PORT(offset) (CKSEG1ADDR(AR7_REGS_UART0) + (4 * offset))
>> #endif
>>
>> -#if defined(CONFIG_MACH_JZ4740) || defined(CONFIG_MACH_JZ4780)
>> -#include <asm/mach-jz4740/base.h>
>> -#define PORT(offset) (CKSEG1ADDR(JZ4740_UART0_BASE_ADDR) + (4 *
>> offset))
>> +#if CONFIG_MACH_INGENIC
>
> I think you meant #ifdef there.
>
> Cheers
> James
Oops. Will fix in V2.
-Paul
next prev parent reply other threads:[~2018-03-25 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-17 20:11 Paul Cercueil
2018-03-22 10:26 ` James Hogan
2018-03-25 14:38 ` Paul Cercueil [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-03-05 17:07 Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521988707.2054.0@smtp.crapouillou.net \
--to=paul@crapouillou.net \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®