From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbcILPn5 (ORCPT ); Mon, 12 Sep 2016 11:43:57 -0400 Received: from mail-bl2nam02on0081.outbound.protection.outlook.com ([104.47.38.81]:64512 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753798AbcILPnn (ORCPT ); Mon, 12 Sep 2016 11:43:43 -0400 Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=amd.com; Subject: Re: [RFC PATCH v2 13/20] x86: Decrypt trampoline area if memory encryption is active To: Borislav Petkov References: <20160822223529.29880.50884.stgit@tlendack-t1.amdoffice.net> <20160822223757.29880.24107.stgit@tlendack-t1.amdoffice.net> <20160909173442.wypsprnzb5ax6xqb@pd.tnic> CC: , , , , , , , , , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Arnd Bergmann , Jonathan Corbet , Matt Fleming , Joerg Roedel , Konrad Rzeszutek Wilk , Andrey Ryabinin , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Paolo Bonzini , Alexander Potapenko , Thomas Gleixner , Dmitry Vyukov From: Tom Lendacky Message-ID: <15219992-dfca-aaa4-4a98-593ed85e1e8f@amd.com> Date: Mon, 12 Sep 2016 10:43:32 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160909173442.wypsprnzb5ax6xqb@pd.tnic> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BY1PR14CA0031.namprd14.prod.outlook.com (10.161.91.41) To DM5PR12MB1147.namprd12.prod.outlook.com (10.168.236.142) X-MS-Office365-Filtering-Correlation-Id: 0cf0647d-7126-4a07-7dc3-08d3db239166 X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;2:eFd8DYApcC5og4OPwXqiGGHeks+hAWORYQqXVSoV+JXXDW0svSOOyQnmezscGbouMtVBSIrq11chQ7DXR+UBQbF4TPr4NUl3n8tTBdV+5cMASFnp3+3EDk4RcBmV2xFQ1BxVl4tsDdZI1saB3RNPQkHAg3HvwNz8Vr/aZNiWcEGMOZfyJThpZEpg5Llet94v;3:vhtL5gaaA6JANcGyf6w+rCG/2xwPDbQNPtW4wKYBDD0l2O74E9xsyPnZhyj6YMQebcCp8eQa78bhnlx7xzUuwIevPQxDT8Wqy5DY1VdkFoQnBM+ZHTN2+c8wc7ybNpLd X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1147; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;25:ReJ9FXiJvSPBTRAmcdUi2HGpBzlB5wrAdECNT6ovzlDKrkGxKUxyG6/IN5qO+/PWeH9rIly7WnfWopDZkW5+juzz0XypOiOPRrFn/sxLinwsQ/2KDsxzCImbFa4eAmURclIRhytqptKjZUUMGPevxXBodyy5ulmF/tOkvzfHoTYCVD4d4UvX9BzW8dU2fHLs2S3F0Pxt57OK5Fdo7pbOyZjpjd4LQRLb5dUEZUzkKs1APm/PtIzE576MBMQHh8G9Tg2DwLjd9RbIIlxubuC8B3dB6a39li0/qT0zD/YSlK9BMPYJbau0Ebvd5uxmPGvP4Z342M3GOx97caLDcbW6wGYkzAbTEMkLNuhapN0g+89EoOCu/clHhC5grE01a5gTd416ZIEORKaR1QaZI3Bv0NL9nRu00ZOLhar2DHwjpABpvE/OMjq8bugDPUK4yJlIdy1J8x4NUtuV+DmLyZWJU1kCR607NzewGxInQP04d5Kqkjy0bKL5Fmg30Ma5WWbyrH7rkcW4BsXlFDFDtnLFPmbv96NEHOtN43cqKz9Xi3ljcpBejSKHgVG8tW0Wz9Rwo1HiRe86MN5p/WXeJtZwDiyHzGvd/Lvv/nuFxMQGy/rZw8rAH/vsSMSHyqfAGt98r8OpmAlYjv+IJePjwWswh5YQcGtfRdq96qwehzBcf9L/G+5Oe2lbBfDC7HBlNSZK6laNg1j/mqcmXD1MVl5gtJ31u2tYarAjUG7wMJtRodw= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;31:6Tfui9qm6EuQLB6OCYfjPuk2egmTvu1eC48yAIXw88GDD67kqwEl+zPFS4Xgyqjy0jP+2YgTeHfRJOvxxbkRGOaGFp1iaNVCz+8lc7FYPXPUGucwyyO7fGVsxSHrqGe7JJcQUsDintk29Y0mTtZfeosZEbSC2bTJKcmAINQL4ZoBjBIQPXZCTJawvc1NCkBaxf/NCtJ46KHPzthHia+7KjP5sV+OSvor3tQLRU869Ro=;20:aV+KXrux383bAUphvbO27qVZv8KUQLRpHICjDcI+OO4ikMw+EBiV1U7BKErD3X6HssSf2+NE5/4ynZlFHYb0jOsiifUnu8pVa7+0OA7niE6AC1T9pGD7NBMXXoZBbsLWotfxXqaiTB2cL38vhzBUxB4qqi6ejY/sbCDBua2IUrMvbBGXFnWiQ3LDOC1FTttVr7QznTV5p+lWjS0MDMUQQTLaygYBKa15NfOo1EATR8mbzNiM2gP8SpUrVcL68dPHl1C3a/xaU5yCaXJUGis33RyahAUyij9maimfXP4KeVflT+K2jGB9b7vW52XRShvSYNfV8t/qx81Hd2xn2TNCf+3P74ECLIKAb8j0eApyf7vZCmPg0QY6bvMBEiRuP6/+Ge/k6x2YxtkN+3xG/Kz05QR5EfzTk4zhJ+hgz7JMONm1A7+DHMiKrIVuckNPgMpjmfUH4ga4ftqVPYtULFw7DOowm6QO+E5+6793hNtNzuKOtlCYDIK99Li4vmU6EGPm X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:DM5PR12MB1147;BCL:0;PCL:0;RULEID:;SRVR:DM5PR12MB1147; X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;4:cANZuH8MAg9boLf9uWR3Avrz1FOk8F3/LvDztGYICwVil/bxsLudmUQ6keJiUzvrE1Bgki9g0ndEwf27DlodoLSd97SIBJ/ZjXjR73vwYUeQ8e9dDzNQS+mRRKZwgWL6boFljeloGOAZ1DpXzPykoNG0UG6dOc0LNqGbzox3xJTGhiWu5wE7M2SzfA8w5sL+fntHDJclZKixLzMCV45rovSEW8XxdTsqrfrJpinaHbr7N7+d0CZDEThgTA/IPceTLB22dqZ0JWYDtF2R79vMBk6+MPSClD743euxeYOL8hnbSkXRp2KSZoOkfVlJjFNXBD4X8VBBfxx0Oj/OzL+rQb2WQj06seiYpSmmSo7d6Ng4ttZY0xfJtIWdcJOE1HIF/NRfrn7LTaoVSjKbkeqnDBbtjtUzn1GSlNl0knt/Mru3bNRsgvbRTDYm1aWVbbXn X-Forefront-PRVS: 006339698F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(7916002)(24454002)(377454003)(23676002)(31686004)(230700001)(586003)(33646002)(42186005)(2906002)(87386001)(31696002)(50466002)(64126003)(50986999)(76176999)(36756003)(65826007)(54356999)(5660300001)(92566002)(86362001)(6116002)(7416002)(47776003)(110136002)(189998001)(4326007)(3846002)(77096005)(83506001)(65956001)(7846002)(65806001)(4001520100001)(19580395003)(2950100001)(4001350100001)(19580405001)(66066001)(81166006)(8676002)(305945005)(7736002)(5004840100003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR12MB1147;H:[10.236.18.82];FPR:;SPF:None;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjEyTUIxMTQ3OzIzOnZlSmRTdkQ0U1VxOHNRTW42aXVjaXdvMith?= =?utf-8?B?OWpkWTZEeXBhUVkrejNtZFYzTHE1d1Y2Nno5ODBBVE1nb3NhTlVROHpBajNt?= =?utf-8?B?blNLWnpMRHdUZXhSRXNqaDVuTVk3djZEZ3dObkdSYmtKK2NBZ09KMDU2NTdk?= =?utf-8?B?bEFjTE1FS2xBZlFHVnpkVCtNSitteUhYamwvek90Nm9nWkJjTllweFNsZXBB?= =?utf-8?B?dmZxTXJaaDgyUndwVE9OZkl1TStYNENnUGFIbnR4ZGxtd0V5QjcrODZTZHFW?= =?utf-8?B?Wkt3NFJTUlZxQUh2dU9aS2phRmVJbFZ3MlY4T2xOeHI0ejNhWWNONnVJTllm?= =?utf-8?B?aEZQMUMxSVBGaDBwWmJwc3BBNjJNMkpYc085bFMwZTZtdUFJUkE5SnNhMEZD?= =?utf-8?B?YVZkV2crdnd3YVdyakx0dm8zTHU4YnlvUElrMUdzakZtMWF3aGQ3TEUyeG0r?= =?utf-8?B?T1pseUlIYXUxVjhOWlFMU0FaNno5N0wySW1hM2hPRG9BNVQ4V1ZTTzJyYkNz?= =?utf-8?B?dzFYbkwvM2VBOWVJUnlCUlZ3TmFDOHhMOFo4eWpPVGZJUEpueDVWTWY3akNI?= =?utf-8?B?akpmYW9JbXdlRmkyTUFWNjA3WFQwUllmMVBQYXR0R2NRb25jRWl3TXdLVDNj?= =?utf-8?B?Z3JOUFlMR0FPUjcveFJ6UEtBNitlR09SQzBrOWZpS3k1aFZLemhsMEs1UWlr?= =?utf-8?B?KzJFZU1xcmFINnh6R0lkc2p0WElMdkJoY2U2NzdnM1hGNyt2Mm9LRVRsc3hS?= =?utf-8?B?bUFJYjJNLy90a001d2laRnFPNHRLSlJRUVBGU3hKRG53bzl2N2ZYaGNuTHo0?= =?utf-8?B?OUlCS1pKWG1NUU9xRUNseFVGRUJTMEwxc0pRaTJCaXh6VjNaTXhvWFQ1T29R?= =?utf-8?B?Ym1JdFp3b1Z6NkNDVmk1aFVRaEREWUdRMWZyWFhwOXE3TmpZNmtsbmJ6OVpG?= =?utf-8?B?VUJMTDAyUitnbWZucENwcGxrQlBJWFV0MTNOUDNQdW0ySVNKdythN0dJSVNC?= =?utf-8?B?VnNZTzcyS0E4WDh5SGtaU1ZEVEgvWnhmUWNsQmJRQXJ3UDFqaGlKOVpsSDJ2?= =?utf-8?B?MHA5T3NxblBsWjBjYndzUVYrSnhJcnJnUEE0QkROcHlsaWRpc2FKZVRzdHhm?= =?utf-8?B?ZmxPcXNaOStieXlrSVV1NWJGTWpQbTRpdmd5bEVHYjltRmoxVDVJeUFYNmZj?= =?utf-8?B?RDU4TUp3TE13dnlJL0xoNFBDOEpETnBqb21FUU02em9WQWJ1M2xrTmNzcGU1?= =?utf-8?B?d0NjWU4vaU5mQ2JVdkl6M0N3ZFIyeDh4ZkhBMjArM2NoVjBsZTFrQmxvWWxY?= =?utf-8?B?alowcWFXT2k2MzM4R0pnalcvci8vaWp0QUlhQlVJamF4cWR6bUF3Q0lRMWRa?= =?utf-8?B?YWNXL2xldE9lcXh0ekhibG1KMjVJS010MTZIZncvY0o3VzM3RWU3OXNEN2xh?= =?utf-8?B?UWpHRDVYZmc0WEF2eWswVFo4TVVVQjlzNy85cERJek5LTHFXWmwydkR5S1Nk?= =?utf-8?B?eHhmajlQdmRpeitaVS8wNjBUQ0ZHTk5CVytDVHFiWDVpTW5BMTllY2pWalZY?= =?utf-8?B?NzV0a2JpTEh4VUVMc1d3OWtxSCt0RG1YWE9VODZBclFZL09vQURkVTBpVGxw?= =?utf-8?B?em5zMER5K3pUQVZocFBFNTU4Q0FHYjBGN25BOXlNTzkrelZvU25mQ1E4Mkpy?= =?utf-8?Q?1TzHUUE5M6M7kPRLwg=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;6:oTK8JK5IV/hTCerkBUGk3u+/S3HdLbeCV5Y7rLoY8gRrOKW0FFHvvxoDd45JbbfDw6KykanyUSTQCu7lgZA2k4ib1/NqIOSgKIJNrMsOe2S+LkIs+WCl9xnKWrVxk/pCe5iZ+q27jiuU/n7srjukFTOO0VsdAqdewXGUwEE0rZqYs8/c6tX9payPPtu2zy2qAJoNf0+HaLP2/z9xJmpgzau/u8wD7VpeokKRTcsQud8Vw5Jd+x0v6dl3V3JKLm+PF5k3Jzh8HHdDttTxQHn7svlKznWB7kI+XVe44fA5xNNRc1//7xsqsnDuANwLSrl+wHxBMOGWh6Etq8yqj7yVQw==;5:vOEn+a0qfNF6KSVCpYhnFGOeq79SQuta/wkzDR/Bj+BO/5/MjsL3savFSgLFdvWrz4sZUWsoBb2Unlzxf+LyL7uNSxN9o5muzK4roU2XXP8/q3lKiaRtohk1NroyZmnoggRWfUEhznXevQjRWeanSQ==;24:DfXy8H7VuFc5icukKgCkcxaTjvb76bMHlc6VpVz6D7NLY/4ckcreYn4IhBJWW0Q1+YU1taSUwJRoueIi+Z7AIm3b/uhVSc2IaryK4IMm+lE=;7:6fjLn2qzCsifpCT5cQAHaeJo65Ea6ceyYc92BoFplsQeEUtoCq8Sb4ybtrWghI91cymSJIUHJAtNiCGU3mJ3WvbCpdHx83rFNgKhPzb8zGmqAEbZd/tAd7VauxfzXlUcJb63kawLh6LResQpLapsDHl5e+5V5PvCDp61gNeuiBESGzOYRVyD8ZgrO6vLlMQM+AXGBoaNoRnZHoZ6Z9Ju+T6WhffPbAttv+hhJcwEZF6XI6UeEoKjFQM7z+wOI85m SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR12MB1147;20:7+3WbrR1n2sduqP/ZNxILLQNIvWYr8cLL2Ein+SU4IeyoG2qEhyVZRuQwyX81E9wByjHo/1EnlBz97nvdN/SU7GWrJl5uYdKLtUcmK3Z/xWAe64dmwqeMFC/Kd6m3oh/kwdMHP5wontt+Lv3EdBcVUbFcXhG5g47ShZTUADAFfEgg+EIvVoZIbSoACWLNonH0Q0rXw2Odc5Rzqkacn1Y66vIQd4fYHSe/oUVd3G/a0WR64wf5Ydm90K625OeKLWb X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Sep 2016 15:43:37.5834 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1147 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/09/2016 12:34 PM, Borislav Petkov wrote: > On Mon, Aug 22, 2016 at 05:37:57PM -0500, Tom Lendacky wrote: >> When Secure Memory Encryption is enabled, the trampoline area must not >> be encrypted. A cpu running in real mode will not be able to decrypt > > s/cpu/CPU/... always :-) Ok. > >> memory that has been encrypted because it will not be able to use addresses >> with the memory encryption mask. >> >> Signed-off-by: Tom Lendacky >> --- >> arch/x86/realmode/init.c | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/x86/realmode/init.c b/arch/x86/realmode/init.c >> index 5db706f1..f74925f 100644 >> --- a/arch/x86/realmode/init.c >> +++ b/arch/x86/realmode/init.c >> @@ -6,6 +6,7 @@ >> #include >> #include >> #include >> +#include >> >> struct real_mode_header *real_mode_header; >> u32 *trampoline_cr4_features; >> @@ -130,6 +131,14 @@ static void __init set_real_mode_permissions(void) >> unsigned long text_start = >> (unsigned long) __va(real_mode_header->text_start); >> >> + /* >> + * If memory encryption is active, the trampoline area will need to >> + * be in non-encrypted memory in order to bring up other processors > > Let's stick with either "unencrypted" - I'd prefer that one - or > "non-encrypted" nomenclature so that there's no distraction. I see both > versions in the patchset. Yup, I'll audit the code and make everything consistent. Thanks, Tom >