From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F4621DF25C for ; Thu, 8 May 2025 12:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746706639; cv=none; b=tPopZ6wK8oKjvRwIVT07EhSJ7Ta/VOtvwwVd4zgd4LQiCsVSVE2Q3+JTuv7Q9yZ7eq3L5sEqtUpl3Vr/vUfsrZSmSmeS1cdIVbOxCOTogIwfgC8FOyd6BbDZrfPS8x9YN2SqnHGK6qr7CiGORjz5OXxnFJcAc2q3nNkN/qtUpis= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746706639; c=relaxed/simple; bh=gI9+15/uiqpn2T7b42r1EP83YhqQAQmZi3IavWEk6Js=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DISiw90Q+VW71ux6XSpXTJ+1KRjCSQrDiz/fEM7BID+yFhvpmYknEimgEgMUUvw+nsjgcQPO0zEIaPOLwFK2cWbahw4vA6f3SfHVVvuQG2fBVYyYKClKajxuhReWnuUOqLZDFmONlZ96UKFHjLFBzuGz4+rjUgAIm0VRIR7zQto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=k3w/widk; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="k3w/widk" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-85b3f92c8f8so86695239f.1 for ; Thu, 08 May 2025 05:17:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1746706636; x=1747311436; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ITsof7vKMaX3jP45vYP8VvBDvnD7ar/ly91W1po1fYs=; b=k3w/widkR97bsDT61lsM4hK+UnsGe+OLVgb5KbiBJQYmL7Idof7dIWDZQ5Aj5LJrKV bZpxNWRFsDQtVkJC4jRsuxXKcunGSpiy691CTRdWzD9pnGhizU9V4lf5zD/14wKzk2Na ShQCKJzCBKRFn1+nPMy0b7mZuEIsZ8Rb9OIV0VR4oAt/AFyhgMaGF+QBrhbS9+WCWaYv lYZ8IVJTGxULjIswSIhurxkME4u6UUmu4o4daWrZD6OS7l7Ub7nlAtxsoumelTadM6m2 quwsUd9lD8NdnnkWHea/Z4sZI6S6bkE9QCLhSWXYePs+1Cb9XY+gggvcYO/s8IwnlfYD eFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746706636; x=1747311436; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ITsof7vKMaX3jP45vYP8VvBDvnD7ar/ly91W1po1fYs=; b=Ubgq1oKImMgKYm7V0PjYr+lyMqmcKFZc/XFyW7JFf1aLQZonwrK6hVmAxIQeiV2WTz MoDIn448Qt/Uo5OjQs8MKSwspoZ2OcfbPP4uX85sdUut0U685wDGGKYVu5x+hr3Aa2wb nbahPEPLk0ofJig1wt0ay3TZA4EJQP6AHcyuI7BDv+cczdL+AfHsDDG3AAFZk4cUuN+i V53YYgMAJXJvRz9rra5ia+SewSQ6d/kyiMmYUbCXkSjjsxNYtJ1tVzQ1zNXBvR+6nX5y hZJIDpEw/vpJWTGeUQuFU/5BSxwdZP1asCJ7IbSsfqlk6+ayBfYIaQ/j1LW9D76a1r24 BctA== X-Forwarded-Encrypted: i=1; AJvYcCWVDfF3cLk+QdiuT9PtZv7xEoYF2zdQhGWYnZgeSPh5Ov/EFzKMeShmzypRnfa9FDQGkzfTIQqgHJHq0DE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7lxWU0Rdx6W6McwpkfKYMQA9cOB+yzsTOCzaRBFKwuWE6QDb0 /d26/SM0qpvl/n/H6vLy2148zBlxPw1T0qK+JM8frU58HzEptGrbniUGoWgAhPg= X-Gm-Gg: ASbGncum5xDPpU8+fo1/7hRPShP2fWS+QRpCeisorj2qNXu9dihDXi054SRQ5m9yzXi TBXX0Yu3bNAS8ICxLtbqlW3WVzJ9myiHdVrm2DLRG3t5OjclVPREJl5KnGcmG0blkL2l4g1akgD TKf8BwpJqpeIlqPXY6X4vHOGj+8+5IlpPA0XCEKXV8ZCKwcNUC99EPKimJSYdHaWFCfVbnbGx9b waxyyYNdzY/j27Cfz1huUkHzmDvwbeMmGsFtEmcHb1CMc2fZjFIrlNy3OgK2OjN5YRR9X0B8JcE gpZBavuyzZjsSgh/QG32bGTFgHymG+XV7LjWar8raP2EtLXZqBAE7/jb0xVD8u26jxWVupWJeqK pYnxT X-Google-Smtp-Source: AGHT+IEpsfxrAkflVw0/hRABTEz4CwO/hvBuswU8lzk6t7nrXFnCj3fyA636Nq30np0oFo7xbeEBJA== X-Received: by 2002:a05:6602:3f85:b0:867:3e9e:89db with SMTP id ca18e2360f4ac-867473170e3mr934513939f.8.1746706636487; Thu, 08 May 2025 05:17:16 -0700 (PDT) Received: from [172.22.22.28] (c-73-228-159-35.hsd1.mn.comcast.net. [73.228.159.35]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-864aa2bb1bdsm294250539f.7.2025.05.08.05.17.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 05:17:15 -0700 (PDT) Message-ID: <1521c828-31f3-4e45-a651-750ce2e37364@riscstar.com> Date: Thu, 8 May 2025 07:17:14 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/6] dt-bindings: soc: spacemit: define spacemit,k1-ccu resets To: Krzysztof Kozlowski , Yixun Lan Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, p.zabel@pengutronix.de, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, heylenay@4d2.org, inochiama@outlook.com, guodong@riscstar.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, spacemit@lists.linux.dev, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20250506210638.2800228-1-elder@riscstar.com> <20250506210638.2800228-2-elder@riscstar.com> <20250507223554-GYA505240@gentoo> <22b7b5fc-6f5a-4ce8-ae12-a7423925c113@kernel.org> Content-Language: en-US From: Alex Elder In-Reply-To: <22b7b5fc-6f5a-4ce8-ae12-a7423925c113@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/8/25 7:02 AM, Krzysztof Kozlowski wrote: > On 08/05/2025 00:35, Yixun Lan wrote: >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - spacemit,k1-syscon-apbc >>> + - spacemit,k1-syscon-apmu >>> + - spacemit,k1-syscon-mpmu >>> + then: >>> + required: >>> + - clocks >>> + - clock-names >>> + - "#clock-cells" >>> >>> additionalProperties: false >>> >>> diff --git a/include/dt-bindings/clock/spacemit,k1-syscon.h b/include/dt-bindings/clock/spacemit,k1-syscon.h >>> index 35968ae982466..f5965dda3b905 100644 >>> --- a/include/dt-bindings/clock/spacemit,k1-syscon.h >>> +++ b/include/dt-bindings/clock/spacemit,k1-syscon.h >> would it be better to move all reset definition to its dedicated dir? >> which like: include/dt-bindings/reset/spacemit,k1-syscon.h? > > Please kindly trim the replies from unnecessary context. It makes it > much easier to find new content. > > > I don't get why such comments are appearing so late - at v6. There was > nothing from you about this in v1, v2 and v3, which finally got reviewed. Stephen Boyd said "please rework this to use the auxiliary driver framework" on version 5 of the series; it was otherwise "done" at that point. Doing this meant there was a much clearer separation of the clock definitions from the reset definitions. And Yixun's suggestion came from viewing things in that context. Given the rework, I considered sending this as v1 of a new series but did not. > I just feel people wait for maintainers to review and only after they > will add their 2 cents of nitpicks or even some more important things > potentially invalidating the review. Lesson for me: do not review > people's work before it reaches v10, right? That's not what happened here--or at least, it's not as simple as that. Your quick review was very much appreciated. Yixun: Krzysztof was satisfied with things the way they're defined here. Do you feel strongly I should make your suggested change? Or are you OK with me just keeping things defined this way for the next version? I'd like this question resolved before I send the next version. Thank you. -Alex > Best regards, > Krzysztof