From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: Felipe Balbi <felipe.balbi@linux.intel.com>, linux-usb@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Vivek Gautam <vivek.gautam@codeaurora.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] usb: dwc3: of-simple: use managed and shared reset control
Date: Thu, 29 Mar 2018 15:07:56 +0900 [thread overview]
Message-ID: <1522303676-7035-1-git-send-email-yamada.masahiro@socionext.com> (raw)
This driver handles the reset control in a common manner; deassert
resets before use, assert them after use. There is no good reason
why it should be exclusive.
Also, use devm_ for clean-up.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
CCing Philipp Zabel.
I see his sob in commit 06c47e6286d5.
drivers/usb/dwc3/dwc3-of-simple.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index e54c362..bd6ab65 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -91,7 +91,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, simple);
simple->dev = dev;
- simple->resets = of_reset_control_array_get_optional_exclusive(np);
+ simple->resets = devm_reset_control_array_get_optional_shared(dev);
if (IS_ERR(simple->resets)) {
ret = PTR_ERR(simple->resets);
dev_err(dev, "failed to get device resets, err=%d\n", ret);
@@ -100,7 +100,7 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
ret = reset_control_deassert(simple->resets);
if (ret)
- goto err_resetc_put;
+ return ret;
ret = dwc3_of_simple_clk_init(simple, of_count_phandle_with_args(np,
"clocks", "#clock-cells"));
@@ -126,8 +126,6 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
err_resetc_assert:
reset_control_assert(simple->resets);
-err_resetc_put:
- reset_control_put(simple->resets);
return ret;
}
@@ -146,7 +144,6 @@ static int dwc3_of_simple_remove(struct platform_device *pdev)
simple->num_clocks = 0;
reset_control_assert(simple->resets);
- reset_control_put(simple->resets);
pm_runtime_put_sync(dev);
pm_runtime_disable(dev);
--
2.7.4
next reply other threads:[~2018-03-29 6:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 6:07 Masahiro Yamada [this message]
2018-04-03 8:00 ` Philipp Zabel
2018-04-03 8:30 ` Masahiro Yamada
2018-04-03 8:46 ` Philipp Zabel
2018-04-03 10:19 ` Masahiro Yamada
2018-04-03 10:35 ` Vivek Gautam
2018-04-04 1:25 ` Masahiro Yamada
2018-04-04 8:18 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522303676-7035-1-git-send-email-yamada.masahiro@socionext.com \
--to=yamada.masahiro@socionext.com \
--cc=balbi@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®