From: David Howells <dhowells@redhat.com>
To: Minjie Du <duminjie@vivo.com>
Cc: dhowells@redhat.com, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] netfs: use kfree_sensitive() instend of kfree() in fscache_free_cookie()
Date: Mon, 08 Jan 2024 13:55:50 +0000 [thread overview]
Message-ID: <1522748.1704722150@warthog.procyon.org.uk> (raw)
In-Reply-To: <20240108112713.20533-1-duminjie@vivo.com>
Minjie Du <duminjie@vivo.com> wrote:
> linux-cachefs@redhat.com (moderated
> list:FILESYSTEMS [NETFS LIBRARY]), linux-fsdevel@vger.kernel.org (open
> list:FILESYSTEMS [NETFS LIBRARY]), linux-kernel@vger.kernel.org (open list)
In future, could you edit the comments out of the email addresses, please?
> key might contain private information, so use kfree_sensitive to free it.
> In fscache_free_cookie() use kfree_sensitive().
There's no real point. These are written as filenames (possibly base64-ish
encoded) on disk by cachefiles and represent the information given to the
server to indicate the file (in afs, for example, that's cell name, volume
name, vnode number).
David
prev parent reply other threads:[~2024-01-08 13:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-08 11:27 Minjie Du
2024-01-08 13:55 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522748.1704722150@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=duminjie@vivo.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®