From: Matt Redfearn <matt.redfearn@mips.com>
To: James Hogan <jhogan@kernel.org>, Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>,
Matt Redfearn <matt.redfearn@mips.com>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
<linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: [PATCH 5/5] MIPS: perf: Fold vpe_id() macro into it's one last usage
Date: Tue, 3 Apr 2018 13:31:31 +0100 [thread overview]
Message-ID: <1522758691-17003-6-git-send-email-matt.redfearn@mips.com> (raw)
In-Reply-To: <1522758691-17003-1-git-send-email-matt.redfearn@mips.com>
The vpe_id() macro is now used only in mipsxx_pmu_enable_event when
CONFIG_CPU_BMIPS5000 is defined. Fold the one used definition of the
macro into it's usage and remove the now unused definitions.
Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
---
arch/mips/kernel/perf_event_mipsxx.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
diff --git a/arch/mips/kernel/perf_event_mipsxx.c b/arch/mips/kernel/perf_event_mipsxx.c
index bedb0d5ff3f2..44b9090a53cc 100644
--- a/arch/mips/kernel/perf_event_mipsxx.c
+++ b/arch/mips/kernel/perf_event_mipsxx.c
@@ -134,18 +134,6 @@ static int cpu_has_mipsmt_pertccounters;
static DEFINE_SPINLOCK(core_counters_lock);
static DEFINE_RWLOCK(pmuint_rwlock);
-
-#if defined(CONFIG_CPU_BMIPS5000)
-#define vpe_id() (cpu_has_mipsmt_pertccounters ? \
- 0 : (smp_processor_id() & MIPS_CPUID_TO_COUNTER_MASK))
-#else
-#define vpe_id() (cpu_has_mipsmt_pertccounters ? \
- 0 : cpu_vpe_id(¤t_cpu_data))
-#endif
-
-#else /* !CONFIG_MIPS_PERF_SHARED_TC_COUNTERS */
-#define vpe_id() 0
-
#endif /* CONFIG_MIPS_PERF_SHARED_TC_COUNTERS */
static void resume_local_counters(void);
@@ -381,8 +369,10 @@ static void mipsxx_pmu_enable_event(struct hw_perf_event *evt, int idx)
if (IS_ENABLED(CONFIG_CPU_BMIPS5000)) {
/* enable the counter for the calling thread */
- cpuc->saved_ctrl[idx] |=
- (1 << (12 + vpe_id())) | BRCM_PERFCTRL_TC;
+ unsigned int vpe_id = cpu_has_mipsmt_pertccounters ? 0 :
+ (smp_processor_id() & MIPS_CPUID_TO_COUNTER_MASK);
+
+ cpuc->saved_ctrl[idx] |= BIT(12 + vpe_id) | BRCM_PERFCTRL_TC;
} else if (range > V) {
/* The counter is processor wide. Set it up to count all TCs. */
pr_debug("Enabling perf counter for all TCs\n");
--
2.7.4
next prev parent reply other threads:[~2018-04-03 12:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 12:31 [PATCH 0/5] MIPS: perf: MT fixes and improvements Matt Redfearn
2018-04-03 12:31 ` [PATCH 1/5] MIPS: perf: More robustly probe for the presence of per-tc counters Matt Redfearn
2018-04-03 12:31 ` [PATCH 2/5] MIPS: perf: Use correct VPE ID when setting up VPE tracing Matt Redfearn
2018-04-03 12:31 ` [PATCH 3/5] MIPS: perf: Fix perf with MT counting other threads Matt Redfearn
2018-04-03 19:49 ` kbuild test robot
2018-04-03 12:31 ` [PATCH 4/5] MIPS: perf: Allocate per-core counters on demand Matt Redfearn
2018-04-03 20:34 ` kbuild test robot
2018-04-03 12:31 ` Matt Redfearn [this message]
2018-04-03 20:57 ` [PATCH 5/5] MIPS: perf: Fold vpe_id() macro into it's one last usage kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522758691-17003-6-git-send-email-matt.redfearn@mips.com \
--to=matt.redfearn@mips.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jhogan@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®