From: Ben Hutchings <ben.hutchings@codethink.co.uk>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] test_firmware: fix setting old custom fw path back on exit, second try
Date: Tue, 03 Apr 2018 21:10:30 +0100 [thread overview]
Message-ID: <1522786230.2654.124.camel@codethink.co.uk> (raw)
In-Reply-To: <CAB=NE6VD7mqEE3TUpBdYm424dQPTD+np_KmT9R6JQEcBuTMkPA@mail.gmail.com>
On Tue, 2018-04-03 at 12:54 -0700, Luis R. Rodriguez wrote:
> On Tue, Apr 3, 2018 at 12:48 PM, Ben Hutchings
> > <ben.hutchings@codethink.co.uk> wrote:
> > Commit 65c79230576 tried to clear the custom firmware path on exit by
> > writing a single space to the firmware_class.path parameter. This
> > doesn't work because nothing strips this space from the value stored
> > and fw_get_filesystem_firmware() only ignores zero-length paths.
> >
> > Instead, write a null byte.
> >
> > Fixes: 0a8adf58475 ("test: add firmware_class loader test")
> > Fixes: 65c79230576 ("test_firmware: fix setting old custom fw path back on exit")
> > Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
>
> Thanks for the patch! Also can you re-send and address Greg and
> linux-kernel ? There's significant changes to the firmware API on its
> way to Linus to I think if we want to merge this it should go through
> Greg at this point as he also merged some new changes I made to these
> scripts.
OK.
> > ---
> > tools/testing/selftests/firmware/fw_filesystem.sh | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/firmware/fw_filesystem.sh b/tools/testing/selftests/firmware/fw_filesystem.sh
> > index f9508e1a4058..6b63b6bf2661 100755
> > --- a/tools/testing/selftests/firmware/fw_filesystem.sh
> > +++ b/tools/testing/selftests/firmware/fw_filesystem.sh
> > @@ -46,9 +46,11 @@ test_finish()
> > echo "$OLD_TIMEOUT" >/sys/class/firmware/timeout
> > fi
> > if [ "$OLD_FWPATH" = "" ]; then
> > - OLD_FWPATH=" "
> > + # A zero-length write won't work; write a null byte
> > + printf '\000' >/sys/module/firmware_class/parameters/path
> > + else
> > + echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
>
> Odd I am pretty sure I tested this and it worked for me. Wonder what
> it could have been... What shell are you using? I used bash.
Seems to work the same way for me whether I use bash (interactive) or
dash (script interpreter, /bin/sh). But there's no visual difference
between " \n" and "\n"; that's why I used od to show a hex dump in my
previous mail.
Ben.
> Luis
>
> > fi
> > - echo -n "$OLD_FWPATH" >/sys/module/firmware_class/parameters/path
> > rm -f "$FW"
> > rmdir "$FWPATH"
> > }
> > --
> > 2.16.2
> >
>
>
--
Ben Hutchings
Software Developer, Codethink Ltd.
next prev parent reply other threads:[~2018-04-03 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180403194849.csgzr3jllt4f2qb7@xylophone.i.decadent.org.uk>
2018-04-03 19:54 ` Luis R. Rodriguez
2018-04-03 20:10 ` Ben Hutchings [this message]
2018-04-03 20:12 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522786230.2654.124.camel@codethink.co.uk \
--to=ben.hutchings@codethink.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®