From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 996E8334692 for ; Wed, 17 Dec 2025 13:05:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765976727; cv=none; b=ixYqYFvFBHZ3Sr95YXTQ7MjliJY7D5Fzi3cVsNdQgpbHVNXR2OmBXdnp8bZWLcSgB8+wpUrVRw1HnsOcYeZ3iucBPPwwVuJoTFd45lobmwZLYi+hnFXlsVwXLqGDac4zj2Dkt+qAvpMJscQz3FWNf05yFVVNZk172gVd8lIvKPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765976727; c=relaxed/simple; bh=pO4vyT6R27J9rdbyr8kNa6JjCUTFaX2Dxzw48Zd+ugc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uupSmPpH1GYTrLNdJAzu7Vh2xy4ER+g992kZMCTjWWMzvYal/FbmbPAOCFNNamAv/D+Jt0GTa0QRSyMLU9xoprhB7EKx4zsuYPT8ubvcJsqoeNts4svotwCO/N4p5TKeCTuFI3Ch7ixKPaKEGVInESeT33ZLfFkdC1a60ZxLt+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pvf7oly2; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=I1yzVAux; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pvf7oly2"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I1yzVAux" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BHCKoCU3048699 for ; Wed, 17 Dec 2025 13:05:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= uSfWHb6IES6Rgoj7mGPk8W5CHpNouvcX3WwERHmWEBI=; b=pvf7oly2eCM+fM6q ii0/0BSYvb0R1UOSPh8SPAZWUAyZCwa19q7LqoQ+Znne7vMffXZ2jYl5s0GIZh8o /UHtJWogrH+f0qHLaPvy8RPIdKf76gx+hQMlqbhPR34Q9kLJXiJazbacHvIKu31D Xuf6zegg/0wjG/A+J8bVnpBNredEi9bCjPBvZTIK8jdf4kBZ2JNPR1qwO3BEPIko jq/mw9y3CGzGdCnZZTVc+wloOsKL9+7y5rL9hahAD11a3Eqz4G0LebhsrOolm3pA vvrsQkusRNh5gfqZOT8Y6t/SMEe5kmihDhrtpeeimZ3pazAQAXunM5TT9tkXzl2z AopqIw== Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b3jgqa0sn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Dec 2025 13:05:24 +0000 (GMT) Received: by mail-vk1-f197.google.com with SMTP id 71dfb90a1353d-559a4539437so540585e0c.1 for ; Wed, 17 Dec 2025 05:05:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765976724; x=1766581524; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uSfWHb6IES6Rgoj7mGPk8W5CHpNouvcX3WwERHmWEBI=; b=I1yzVAuxLjcjrCT5Cn0TeSA9DCEin1ALIPUZuJN1cMU2WU0QOk/o6LEMAeudQi3H6v BohANO4gzz5Beq0tF2wBePElY+4adGOcDc+6WWEvD/aRP+fbp12Zxc0Uq+AKRt1I0QI0 dWfbSu/fJCBYzbgeO9Kqhgt2RgZQ161+O41PU01NlM2UiBEL+9yKI/T4LOTasqm92s8C AqiL2qyqZ+wPCrMZCNfLon0eFxvvfXXkbxDL03jCBBIEu/lNM3YZ/tyf/lt4t2P9ILAi 3Uo9Y5bsLOQs0iicM5QNRaWaaQA1TeYiw2mH42eTfjSPjVBK6yNNtkbcasYEPQS27XV3 xnFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765976724; x=1766581524; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uSfWHb6IES6Rgoj7mGPk8W5CHpNouvcX3WwERHmWEBI=; b=jlF2nWfvbHnymBz4fxvmhox7Ig+gIlJqPC5S2V82vyYKVmYmHFTGKKljEsn6T/2Ypv Wd4G2QOCdPQrxElNiEr8qb6V5POcRdxE8Rwz4nDgz2atIMjLv+tyxokvQSJyM2BDBvBs jroxkjMW+eBtmqLjzSrZbgdxgoCbiHp8puqCKSJtgDC1GDmPaK+WDYLCdjYBHLi46HfM g7feYdEefuE5Ftc6h2TKhzgJqa6oPrTqV45swf4i2FjAfKllEesdoKDmBuznbe+Lj6OA 3K1VXsITn0rCeeWu34PVV6tj0dlQvLLxKZekOhQ6+4KIshrOSxRnQf1NGOHBMGNQ5q7R th9g== X-Forwarded-Encrypted: i=1; AJvYcCXlz8Jxkb/XjmAGQPoxwIl1hK8dcHcO/a24npAH4kiX6uuwlJfv5BF37rcdCzCsQi0pQVDCQDBcNAOUlQU=@vger.kernel.org X-Gm-Message-State: AOJu0YwrMVKMBJr3+3GRPd5DsOopIyjYnW2uedz9ZwdHy0+6ILs5mOmx lQSS3eH8aAuKsD2kT6uFwa8yQeeJqMPNkl5L7rmlqa80ID6m2G9BT6orkUUaV9NYzkjsmQNeHt9 4tWlbIMvru9lH/ql7UffQt/dfj3Vyp1XIfFgtWuJ7Nz4nsGc8DzM5kF5o3R8XvtGqT9M= X-Gm-Gg: AY/fxX51ZBo95Q0+xOhG3m4KYWk5oUCB+j4wfTLjZ+JGDeH/TeYtYTROxoFrc0a/lEU oOOxJaWxbmnf4hTJDzOpKnoXALiDQ0OSbgLG4g8tZRY1JMTGNnG4iU1lpf766/Kn2zR+Uicv427 e2H7/fI/7gPcL2uFruEAJbcca+XagtWlVDJDR6dv3c2YqO6hN/QE+jkfcCJwxvvDRad6xdZr85M r5LJCgXKVTcTeHsFv7nOBplk26fTHxN7ttmRj+9TT06qfZcpBqahySkf0GfheME+lhxhBba8zPP UBjAD4lyMTkYD9dhwN3mQPnglIDl22xvn6CnoxltepKZm+/ZH8H03Iyh2E6s28FgK7urFt4rQLw Cd6E8bNs8JztBA4b7J+OUNUHatYDJBxnJ4WsFqMURgKtcXq4ylrJqAY8PORqMVpk0eQ== X-Received: by 2002:ac5:cda2:0:b0:55b:ac1:d05f with SMTP id 71dfb90a1353d-55fed4513dcmr3081426e0c.0.1765976723720; Wed, 17 Dec 2025 05:05:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IGNkAmEGb+DEQkMQXhO/klpSQ3KdCkRgLFiz07IuBTxL1i8X9YIGirss2PL9bV3+bxlJNGCPg== X-Received: by 2002:ac5:cda2:0:b0:55b:ac1:d05f with SMTP id 71dfb90a1353d-55fed4513dcmr3081391e0c.0.1765976723213; Wed, 17 Dec 2025 05:05:23 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-64b3f4ea465sm2415418a12.5.2025.12.17.05.05.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 05:05:22 -0800 (PST) Message-ID: <152303f5-ada5-4a54-8909-2f8583fc48c2@oss.qualcomm.com> Date: Wed, 17 Dec 2025 14:05:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: sm8750: Add camera clock controller To: Dmitry Baryshkov , Vladimir Zapolskiy Cc: Taniya Das , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ajit Pandey , Imran Shaik , Jagadeesh Kona , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251203-sm8750_camcc_dt-v1-1-418e65e0e4e8@oss.qualcomm.com> <3e1d1dc4-7b94-47df-b4bd-f6ce4d7842dd@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=VLjQXtPX c=1 sm=1 tr=0 ts=6942aa94 cx=c_pps a=JIY1xp/sjQ9K5JH4t62bdg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=eKbRlcxksK2tBPLDyXgA:9 a=QEXdDO2ut3YA:10 a=tNoRWFLymzeba-QzToBc:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE3MDEwMSBTYWx0ZWRfXygFxLdpolWWl O/lBp/dS15AXqMwgCxr0Xf++egl7PYjuVbROTkqop0JDzrmJpzs8GHai6YrT/bzqkjR4nR3UHmx Vs90la0ZBgdCGIRxUz4YRZseT3XMbuWyd0VGJr17P88pN5jrz+U3c8/BB/XW5AKXykP8cDVQIOK GeckqV6IJ76XDW2Vbnjd+xK74KEo2yPldqOX5Nsdx6NxX6qf76w8rLcYohtdIRTIrSKSFWPYVxm TMxtoU7JgaBHdNZljIZ0DT/Prvyf6Yix5OVK85fIjycyfyGJWOWMOZ60WvCUBob8GgWvU69Z72Q EHSiurKunU9fGtspYIoPARAztLkCwYfd0hTvyPqIbyJY7ZGeaaXGoOiaf+SWgMbhNZRQu2RaIC/ RTD2RkqCk4oCc+tbxHgKaydUUQv74g== X-Proofpoint-ORIG-GUID: A9uHL3vrVNuOGyA3BGm8S_GVN9Yar1N7 X-Proofpoint-GUID: A9uHL3vrVNuOGyA3BGm8S_GVN9Yar1N7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-17_01,2025-12-16_05,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512170101 On 12/6/25 4:45 AM, Dmitry Baryshkov wrote: > On Wed, Dec 03, 2025 at 04:03:26PM +0200, Vladimir Zapolskiy wrote: >> Hi Taniya. >> >> On 12/3/25 12:32, Taniya Das wrote: >>> Add the camcc clock controller device node for SM8750 SoC. >>> >>> Signed-off-by: Taniya Das >>> --- >>> arch/arm64/boot/dts/qcom/sm8750.dtsi | 35 ++++++++++++++++++++++++++++++++++- >>> 1 file changed, 34 insertions(+), 1 deletion(-) > >>> @@ -2046,6 +2047,22 @@ aggre2_noc: interconnect@1700000 { >>> clocks = <&rpmhcc RPMH_IPA_CLK>; >>> }; >>> + cambistmclkcc: clock-controller@1760000 { >>> + compatible = "qcom,sm8750-cambistmclkcc"; >>> + reg = <0x0 0x1760000 0x0 0x6000>; >>> + clocks = <&gcc GCC_CAM_BIST_MCLK_AHB_CLK> , >>> + <&bi_tcxo_div2>, >>> + <&bi_tcxo_ao_div2>, >>> + <&sleep_clk>; >>> + power-domains = <&rpmhpd RPMHPD_MMCX>, >>> + <&rpmhpd RPMHPD_MX>; >>> + required-opps = <&rpmhpd_opp_low_svs>, >>> + <&rpmhpd_opp_low_svs>; >>> + #clock-cells = <1>; >>> + #reset-cells = <1>; >>> + #power-domain-cells = <1>; >> >> I've briefly checked the recently sent driver, and I didn't find that this >> clock controller serves as a reset controller or a power domain controller. >> >> And if so, these properties shall be obviously removed. > > I'd agree here. This block is most definitely a reset provider, but none are described in Linux as of right now I don't see any GDSCs though Konrad