From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-hardening@lists.openwall.com,
linux-crypto@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Kees Cook <keescook@chromium.org>,
Salvatore Mesoraca <s.mesoraca16@gmail.com>,
Eric Biggers <ebiggers3@gmail.com>,
Laura Abbott <labbott@redhat.com>
Subject: [PATCH 1/6] crypto: api - laying macros for statically allocated buffers
Date: Sat, 7 Apr 2018 20:38:18 +0200 [thread overview]
Message-ID: <1523126303-23205-2-git-send-email-s.mesoraca16@gmail.com> (raw)
In-Reply-To: <1523126303-23205-1-git-send-email-s.mesoraca16@gmail.com>
Creating 2 new compile-time constants for internal use,
in preparation for the removal of VLAs[1] from crypto code.
All ciphers implemented in Linux have a block size less than or
equal to 16 bytes and the most demanding hw require 16 bytes
alignment for the block buffer.
[1] http://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
Signed-off-by: Salvatore Mesoraca <s.mesoraca16@gmail.com>
---
crypto/internal.h | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/crypto/internal.h b/crypto/internal.h
index 9a3f399..89ae41e 100644
--- a/crypto/internal.h
+++ b/crypto/internal.h
@@ -26,6 +26,14 @@
#include <linux/rwsem.h>
#include <linux/slab.h>
+/*
+ * Maximum values for blocksize and alignmask, used to allocate
+ * static buffers that are big enough for any combination of
+ * ciphers and architectures.
+ */
+#define MAX_BLOCKSIZE 16
+#define MAX_ALIGNMASK 15
+
/* Crypto notification events. */
enum {
CRYPTO_MSG_ALG_REQUEST,
--
1.9.1
next prev parent reply other threads:[~2018-04-07 18:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-07 18:38 [PATCH 0/6] Remove several VLAs in the crypto subsystem Salvatore Mesoraca
2018-04-07 18:38 ` Salvatore Mesoraca [this message]
2018-04-08 3:15 ` [PATCH 1/6] crypto: api - laying macros for statically allocated buffers Herbert Xu
2018-04-08 8:56 ` Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 2/6] crypto: ctr - avoid VLA use Salvatore Mesoraca
2018-04-08 3:19 ` Herbert Xu
2018-04-08 8:58 ` Salvatore Mesoraca
2018-04-08 9:18 ` Herbert Xu
2018-04-07 18:38 ` [PATCH 3/6] crypto: api " Salvatore Mesoraca
2018-04-08 3:16 ` Herbert Xu
2018-04-08 9:07 ` Salvatore Mesoraca
2018-04-08 9:22 ` Herbert Xu
2018-04-09 13:27 ` Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 4/6] crypto: pcbc " Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 5/6] crypto: cts " Salvatore Mesoraca
2018-04-07 18:38 ` [PATCH 6/6] crypto: cfb " Salvatore Mesoraca
2018-04-07 19:56 ` [PATCH 0/6] Remove several VLAs in the crypto subsystem Kees Cook
2018-04-08 8:55 ` Salvatore Mesoraca
2018-04-09 13:53 Salvatore Mesoraca
2018-04-09 13:53 ` [PATCH 1/6] crypto: api - laying macros for statically allocated buffers Salvatore Mesoraca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523126303-23205-2-git-send-email-s.mesoraca16@gmail.com \
--to=s.mesoraca16@gmail.com \
--cc=davem@davemloft.net \
--cc=ebiggers3@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®