From: Jack Wang <jinpu.wang@profitbricks.com>
To: axboe@kernel.dk
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Jack Wang <jinpu.wang@profitbricks.com>
Subject: [PATCH] block: ratelimite pr_err on IO path
Date: Wed, 11 Apr 2018 15:21:29 +0200 [thread overview]
Message-ID: <1523452889-16331-1-git-send-email-jinpu.wangl@profitbricks.com> (raw)
From: Jack Wang <jinpu.wang@profitbricks.com>
This avoid soft lockup below:
[ 2328.328429] Call Trace:
[ 2328.328433] vprintk_emit+0x229/0x2e0
[ 2328.328436] ? t10_pi_type3_verify_ip+0x20/0x20
[ 2328.328437] printk+0x52/0x6e
[ 2328.328439] t10_pi_verify+0x9e/0xf0
[ 2328.328441] bio_integrity_process+0x12e/0x220
[ 2328.328442] ? t10_pi_type1_verify_crc+0x20/0x20
[ 2328.328443] bio_integrity_verify_fn+0xde/0x140
[ 2328.328447] process_one_work+0x13f/0x370
[ 2328.328449] worker_thread+0x62/0x3d0
[ 2328.328450] ? rescuer_thread+0x2f0/0x2f0
[ 2328.328452] kthread+0x116/0x150
[ 2328.328454] ? __kthread_parkme+0x70/0x70
[ 2328.328457] ret_from_fork+0x35/0x40
Signed-off-by: Jack Wang <jinpu.wang@profitbricks.com>
---
block/t10-pi.c | 20 ++++++++++++--------
1 file changed, 12 insertions(+), 8 deletions(-)
diff --git a/block/t10-pi.c b/block/t10-pi.c
index a98db38..35967d5 100644
--- a/block/t10-pi.c
+++ b/block/t10-pi.c
@@ -84,10 +84,12 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter,
if (be32_to_cpu(pi->ref_tag) !=
lower_32_bits(iter->seed)) {
- pr_err("%s: ref tag error at location %llu " \
- "(rcvd %u)\n", iter->disk_name,
- (unsigned long long)
- iter->seed, be32_to_cpu(pi->ref_tag));
+ pr_err_ratelimited("%s: ref tag error at "
+ "location %llu (rcvd %u)\n",
+ iter->disk_name,
+ (unsigned long long)
+ iter->seed,
+ be32_to_cpu(pi->ref_tag));
return BLK_STS_PROTECTION;
}
break;
@@ -101,10 +103,12 @@ static blk_status_t t10_pi_verify(struct blk_integrity_iter *iter,
csum = fn(iter->data_buf, iter->interval);
if (pi->guard_tag != csum) {
- pr_err("%s: guard tag error at sector %llu " \
- "(rcvd %04x, want %04x)\n", iter->disk_name,
- (unsigned long long)iter->seed,
- be16_to_cpu(pi->guard_tag), be16_to_cpu(csum));
+ pr_err_ratelimited("%s: guard tag error at sector %llu "
+ "(rcvd %04x, want %04x)\n",
+ iter->disk_name,
+ (unsigned long long)iter->seed,
+ be16_to_cpu(pi->guard_tag),
+ be16_to_cpu(csum));
return BLK_STS_PROTECTION;
}
--
2.7.4
next reply other threads:[~2018-04-11 13:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 13:21 Jack Wang [this message]
2018-04-11 17:07 ` Elliott, Robert (Persistent Memory)
2018-04-12 8:56 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1523452889-16331-1-git-send-email-jinpu.wangl@profitbricks.com \
--to=jinpu.wang@profitbricks.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®