mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ian Dall <Ian.Dall@dsto.defence.gov.au>
To: linux-kernel@vger.kernel.org
Subject: IPCONFIG fails for BOOTP
Date: Wed, 29 Aug 2001 13:34:31 +0930	[thread overview]
Message-ID: <15244.27087.313164.737903@gargle.gargle.HOWL> (raw)

Kernel version 2.4.8-ac9

I am attempting to set up a linux based xterm. The kernel loads
but times out attempting to get ipaddresses etc in ipconfig.
The following are defined in "include/linux/autoconf.h":

#define CONFIG_IP_PNP 1
#define CONFIG_IP_PNP_DHCP 1
#define CONFIG_IP_PNP_BOOTP 1
#undef  CONFIG_IP_PNP_RARP


A few printk's latter and it seems that the problem is in ic_bootp_recv()
around line 843:

#ifdef IPCONFIG_DEBUG
		printk("DHCP: Got message type %d\n", mt);
#endif

		switch (mt) {
		    case DHCPOFFER:

			 [.....]

		    default:
			/* Urque.  Forget it*/
			ic_myaddr = INADDR_NONE;
			ic_servaddr = INADDR_NONE;
			goto drop;
		}

At this point we could be receiving either DHCP *or* BOOTP extensions.
The code to handle the BOOTP extension follows, but is never executed
because of the "goto drop" in the default case for handling dhcp packets.
If the kernel were compiled without DHCP this problem would go away.

There are two possibilities to fix this. One is to fall through to the
bootp case instead of going to drop, or maybe fold the bootp code into
the default case of the switch statement. The only problem then seems to
be how to conditionalize the DHCP support.

Ian

             reply	other threads:[~2001-08-29  4:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-29  4:04 Ian Dall [this message]
2001-08-30 15:32 H . J . Lu
2001-09-25 23:24 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15244.27087.313164.737903@gargle.gargle.HOWL \
    --to=ian.dall@dsto.defence.gov.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®