From: Rishabh Bhatnagar <rishabhb@codeaurora.org>
To: rostedt@goodmis.org, abderrahmane.benbachir@polymtl.ca
Cc: linux-kernel@vger.kernel.org, tsoni@codeaurora.org,
ckadabi@codeaurora.org,
Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: [PATCH] trace: initcall: Ordered comparison of function pointers
Date: Wed, 25 Apr 2018 16:42:35 -0700 [thread overview]
Message-ID: <1524699755-29388-1-git-send-email-rishabhb@codeaurora.org> (raw)
Using initcall_t in the __field macro generates the follwing warning
with clang version 6.0:
include/trace/events/initcall.h:34:3: warning: ordered comparison of
function pointers ('initcall_t' (aka 'int (*)(void)') and 'initcall_t')
__field macro expands to __field_ext macro which does is_signed_type
check on the type argument. Since initcall_t is defined as a function
pointer, using it as the type in the __field macro, leads to an ordered
comparison of function pointer warning, inside the check. Using
__field_struct macro avoids the issue.
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
---
include/trace/events/initcall.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/initcall.h b/include/trace/events/initcall.h
index 8d6cf10..46f5f7c 100644
--- a/include/trace/events/initcall.h
+++ b/include/trace/events/initcall.h
@@ -31,7 +31,7 @@
TP_ARGS(func),
TP_STRUCT__entry(
- __field(initcall_t, func)
+ __field_struct(initcall_t, func)
),
TP_fast_assign(
@@ -48,7 +48,7 @@
TP_ARGS(func, ret),
TP_STRUCT__entry(
- __field(initcall_t, func)
+ __field_struct(initcall_t, func)
__field(int, ret)
),
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
reply other threads:[~2018-04-25 23:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524699755-29388-1-git-send-email-rishabhb@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=abderrahmane.benbachir@polymtl.ca \
--cc=ckadabi@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®