From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbcHHMs3 (ORCPT ); Mon, 8 Aug 2016 08:48:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50170 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbcHHMs1 convert rfc822-to-8bit (ORCPT ); Mon, 8 Aug 2016 08:48:27 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20160808101357.1583011-1-arnd@arndb.de> References: <20160808101357.1583011-1-arnd@arndb.de> To: Arnd Bergmann Cc: dhowells@redhat.com, "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net] rxrpc: fix uninitialized pointer dereference in debug code MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1524.1470660504.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Mon, 08 Aug 2016 13:48:24 +0100 Message-ID: <1525.1470660504@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Mon, 08 Aug 2016 12:48:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann wrote: > A newly added bugfix caused an uninitialized variable to be > used for printing debug output. This is harmless as long > as the debug setting is disabled, but otherwise leads to an > immediate crash. > > gcc warns about this when -Wmaybe-uninitialized is enabled: > > net/rxrpc/call_object.c: In function 'rxrpc_release_call': > net/rxrpc/call_object.c:496:163: error: 'sp' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The initialization was removed but one of the users remains. > This adds back the initialization. > > Signed-off-by: Arnd Bergmann > Fixes: 372ee16386bb ("rxrpc: Fix races between skb free, ACK generation and replying") Applied, thanks. David