From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752909AbbHRMlr (ORCPT ); Tue, 18 Aug 2015 08:41:47 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:58393 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752469AbbHRMlq (ORCPT ); Tue, 18 Aug 2015 08:41:46 -0400 X-AuditID: cbfee61a-f79a06d000005c6f-ec-55d328071450 From: Bartlomiej Zolnierkiewicz To: Javier Martinez Canillas Cc: Olof Johansson , Geert Uytterhoeven , Doug Anderson , Gwendal Grignou , Sjoerd Simons , linux-kernel@vger.kernel.org Subject: Re: [PATCH] platform/chrome: Make CROS_EC_PROTO a user selectable option Date: Tue, 18 Aug 2015 14:40:12 +0200 Message-id: <1525696.gQFOjPpKHL@amdc1976> User-Agent: KMail/4.13.3 (Linux/3.13.0-57-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <1439882106-23406-1-git-send-email-javier@osg.samsung.com> References: <1439882106-23406-1-git-send-email-javier@osg.samsung.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsVy+t9jQV12jcuhBs0N+hZnlx1ks3h2ay+T xezFR1ks3rxdw2RxedccNotT1z+zWUw//pbVgd1jdsNFFo+/z6+zeBw63MHoceVEE6vHlv67 7B6fN8kFsEVx2aSk5mSWpRbp2yVwZaz+tISxYAZvxbpz6Q2M67i6GDk5JARMJKasOcIOYYtJ XLi3nq2LkYtDSGAWo8T1W8dZIJyvjBI/b/SzgVSxCVhJTGxfxQhiiwiYSvxa+4IVpIhZ4B2j RGtPOzNIQlggWOLi5HNMIDaLgKpE09mpYA28ApoSUxa/ZgGxRQW8JL7/agCr5xRwl+hu+QEW FxJwk7j0dSozRL2gxI/J98DizALyEvv2T2WFsLUk1u88zjSBEehOhLJZSMpmISlbwMi8ilEi tSC5oDgpPdcwL7Vcrzgxt7g0L10vOT93EyM47J9J7WA8uMv9EKMAB6MSD++FgkuhQqyJZcWV uYcYJTiYlUR4JXkvhwrxpiRWVqUW5ccXleakFh9ilOZgURLnld2wOVRIID2xJDU7NbUgtQgm y8TBKdXAuKP1VviS3PNZ+S5JZh/tbS5uW/SbZVsw46w7OWXT3avnvX17u9JfcTnX07y1Mzpe 8CUnPv09eZXPvfR/vz9ad7fUedxZXJLtbVKoLO/yeuMKucvv+xuEWTpdz+/dHPp7f9H+TmMV WyUNdsbMWXnz9HfymprKJR/lj9rnm/hmscqeeHvb5N4oJZbijERDLeai4kQAMNkyOncCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tuesday, August 18, 2015 09:15:06 AM Javier Martinez Canillas wrote: > The boolean CROS_EC_PROTO symbol is selected by MFD_CROS_EC but that can > cause Kconfig circular dependencies so is better to change the select to Could you please give a reference to the problem or error message that you're getting (I was not following the previous discussion). > a depends on. But in order to be able to change that, the CROS_EC_PROTO > symbol has to be one that can be selected by the user. Looking at the code behind the config option it seems that it is just a helper library and should not be made user-visible. Why can't the issue be fixed the other way (make other config options select CROS_EC_PROTO consistently)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Signed-off-by: Javier Martinez Canillas > --- > drivers/platform/chrome/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/platform/chrome/Kconfig b/drivers/platform/chrome/Kconfig > index 3271cd1abe7c..a73b823d4967 100644 > --- a/drivers/platform/chrome/Kconfig > +++ b/drivers/platform/chrome/Kconfig > @@ -59,8 +59,9 @@ config CROS_EC_LPC > module will be called cros_ec_lpc. > > config CROS_EC_PROTO > - bool > + bool "ChromeOS EC communication protocol helpers" > help > - ChromeOS EC communication protocol helpers. > + Say Y here to enable support for the different communication > + protocols used to talk with the ChromeOS embedded controller. > > endif # CHROMEOS_PLATFORMS