mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 宋金时 <songjinshi@xiaomi.com>
To: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"maco@android.com" <maco@android.com>,
	"tkjos@google.com" <tkjos@google.com>,
	"arve@android.com" <arve@android.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v2] ANDROID: binder: correct the cmd print for BINDER_WORK_RETURN_ERROR
Date: Thu, 10 May 2018 02:05:03 +0000	[thread overview]
Message-ID: <1525917903067.93656@xiaomi.com> (raw)

When to execute binder_stat_br the e->cmd has been modifying as BR_OK 
instead of the original return error cmd, in fact we want to know the 
original return error, such as BR_DEAD_REPLY or BR_FAILED_REPLY, etc. 
instead of always BR_OK, in order to avoid the value of the e->cmd is 
always BR_OK, so we need assign the value of the e->cmd to cmd before 
e->cmd = BR_OK.

Signed-off-by: songjinshi <songjinshi@xiaomi.com>
---
 drivers/android/binder.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 764b63a..a85d260 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -3917,10 +3917,11 @@ static int binder_thread_read(struct binder_proc *proc,
 			binder_inner_proc_unlock(proc);
 			if (put_user(e->cmd, (uint32_t __user *)ptr))
 				return -EFAULT;
+			cmd = e->cmd;
 			e->cmd = BR_OK;
 			ptr += sizeof(uint32_t);
 
-			binder_stat_br(proc, thread, e->cmd);
+			binder_stat_br(proc, thread, cmd);
 		} break;
 		case BINDER_WORK_TRANSACTION_COMPLETE: {
 			binder_inner_proc_unlock(proc);
-- 
1.9.1

                 reply	other threads:[~2018-05-10  2:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525917903067.93656@xiaomi.com \
    --to=songjinshi@xiaomi.com \
    --cc=arve@android.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=tkjos@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®