On Thu, 2018-05-17 at 11:10 +0200, Greg Kroah-Hartman wrote: > On Wed, May 16, 2018 at 02:58:02PM +0100, Ben Hutchings wrote: > > On Wed, 2018-04-11 at 20:36 +0200, Greg Kroah-Hartman wrote: > > > 4.4-stable review patch.  If anyone has any objections, please let me know. > > > > > > ------------------ > > > > > > From: Jason A. Donenfeld > > > > > > commit 3f29770723fe498a5c5f57c3a31a996ebdde03e1 upstream. > > > > [...] > > > > This leaves the error paths in esp{4,6}.c leaking memory; fixed > > upstream by: > > > > commit e6194923237f3952b955c343b65b211f36bce01c > > Author: Steffen Klassert > > Date:   Thu Jul 13 09:13:30 2017 +0200 > > > >     esp: Fix memleaks on error paths. > > Really?  That patch doesn't apply at all.  It looks like this patch > fixes things that happened after the above patch. > > Or am I confused? It's partly fixing bugs introduced in 4.12, but it's also fixing similar bugs introduced by the commit that has been backported to stable branches. I've attached a backport to 4.4 that will also work for 4.9 (it has identical versions of esp4 and esp6). I would appreciate a review from those actually familiar with the code. Also, it looks like esp6_input() still has a potential leak both upstream and in stable branches. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.