From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1184171-1526932708-2-7463030589210122311 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.248, MAILING_LIST_MULTI -1, RCVD_IN_DNSWL_HI -5, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1526932706; b=Yp89QiUyVm9TTLfFIGCIrqOlaxhCgSa/fiG6iNkhxh/AXVTWua z5a4JQN4/Ac+vI3mdaZZNJDv7PaX/UY0kpXya49JyiN6SjBhL+pWMcH3kZzRfriE 0/QU5meB1p5+OUh0HdVEW/PjMelV8OcvpO+n6YE3jS+jCLxL4FvsLnEGelW5vITO TAGWudCIJ1gJv+krnz6c9NMpr7D7DwersD3oHLtVUr4FomVsYmzxz4jBWBwlKzjK LiqjoAPDF6gUMB9aWw66hJTwfgshLBsM84bNBLc9L5nuGzlA1sgojeBQlQHwJ6E4 Mf4vYfom4GTSD6Uk4MmFLqnr5yabisLlZb3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id:sender :list-id; s=fm2; t=1526932706; bh=TOIEhXnV2dXmdq/8oCSTk6uNatgblz K2/6TNn9QSQec=; b=dYPg42kjFi3Qp91N4HkuavsKBp7oaxKA5420CtdxuxnG4T QzticWdJb7dvGjcV39QvvvS6TDknvsw7oQC9i3q01gCOwlJPzFtyXa8X6IKPNJ88 hMFkpibhMvaBZwbDORoXkWWdx/G+pu4DxrlAiDSdTBrRP2i/nfUAsonLARUWPv1M rtfb/Yvs8n/RFxOEofzgAH9H6XG9FEKZ3s8HxOfZWEMidCftpGnljlIEsuOD9LFL lVrtwFGcKPrKF1CazWfujsimSsjUe3lZkK+8R5Vz6u2u9TuXxc/DwsOlqY11c2VY 8mAvNgnIRilsvItbXvXND4atLTkXpG0uRNChAQ9g== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered, 1024-bit rsa key sha256) header.d=linaro.org header.i=@linaro.org header.b=jl8JmkVT x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=google; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linaro.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=fail (body has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LuKTfJVv; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linaro.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered, 1024-bit rsa key sha256) header.d=linaro.org header.i=@linaro.org header.b=jl8JmkVT x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=google; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=linaro.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=fail (body has been altered, 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=LuKTfJVv; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linaro.org header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfGpr07SECJhdJM5o3vTiODWO4jG9Mopt7SarWJqLktNbFtAiH54l9wy6yxS+8+J5XDjRIkfdQVfO3gcCqWE3IVaYZiVcbFl9pv8+128tBg0c7ntJjzQn VXRbZk846drQr/Kf3SDJOeFOTkjek5RNGhNDIcHDyiqaYX7/tDZ1t5/Wz2G9SZA1tqzn2sRZQ1IrU2XYIDRrmLinqrh++To8bQLZsmG6H4POxAKOXFYrJpX6 X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=xqWC_Br6kY4A:10 a=VUJBJC2UJ8kA:10 a=jIQo8A4GAAAA:8 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=9f7s3DRQrkJldriD0Y0A:9 a=x8gzFH9gYPwA:10 a=Lf5xNeLK5dgiOs8hzIjU:22 a=AjGcO6oz07-iQ99wixmX:22 a=cvBusfyB2V15izCimMoJ:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751429AbeEUT6Y (ORCPT ); Mon, 21 May 2018 15:58:24 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35528 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbeEUT6Y (ORCPT ); Mon, 21 May 2018 15:58:24 -0400 X-Google-Smtp-Source: AB8JxZrPseJsKk/hhKvKuTsWxBcOrcRTZo0dBhXtESCp2Ya69xcLZN2RR8gINCPiJ69d4ph5np8GSw== From: John Stultz To: lkml Cc: John Stultz , John Youn , Minas Harutyunyan , Artur Petrosyan , Grigor Tovmasyan , Felipe Balbi , linux-usb@vger.kernel.org Subject: [PATCH v2] usb: dwc2: Fix HiKey regression caused by power_down feature Date: Mon, 21 May 2018 12:58:18 -0700 Message-Id: <1526932698-28285-1-git-send-email-john.stultz@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: In 4.17-rc, commit 03ea6d6e9e1f ("usb: dwc2: Enable power down") caused the HiKey board to not correctly handle switching between usb-gadget and usb-host mode. Unplugging the OTG port would result in: [ 42.240973] dwc2 f72c0000.usb: dwc2_restore_host_registers: no host registers to restore [ 42.249066] dwc2 f72c0000.usb: dwc2_host_exit_hibernation: failed to restore host registers And the USB-host ports would not function. And plugging in the OTG port, we would see: [ 46.046557] WARNING: CPU: 3 PID: 6 at drivers/usb/dwc2/gadget.c:260 dwc2_hsotg_init_fifo+0x194/0x1a0 [ 46.055761] CPU: 3 PID: 6 Comm: kworker/u16:0 Not tainted 4.17.0-rc5-00030-ge67da8c #231 [ 46.055767] Hardware name: HiKey Development Board (DT) [ 46.055784] Workqueue: dwc2 dwc2_conn_id_status_change ... Thus, this patch sets the hisi params to disable the power_down flag by default, and gets thing working again. Cc: John Youn Cc: Minas Harutyunyan Cc: Artur Petrosyan Cc: Grigor Tovmasyan Cc: Felipe Balbi Cc: linux-usb@vger.kernel.org Signed-off-by: John Stultz --- v2: Use DWC2_POWER_DOWN_PARAM_NONE as suggested by Minas --- drivers/usb/dwc2/params.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c index f03e418..d38871c 100644 --- a/drivers/usb/dwc2/params.c +++ b/drivers/usb/dwc2/params.c @@ -70,6 +70,7 @@ static void dwc2_set_his_params(struct dwc2_hsotg *hsotg) GAHBCFG_HBSTLEN_SHIFT; p->uframe_sched = false; p->change_speed_quirk = true; + p->power_down = DWC2_POWER_DOWN_PARAM_NONE; } static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg) -- 2.7.4