From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754037AbbIQINM (ORCPT ); Thu, 17 Sep 2015 04:13:12 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:51166 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbbIQIMw (ORCPT ); Thu, 17 Sep 2015 04:12:52 -0400 From: Arnd Bergmann To: WEN Pingbo Cc: linux-usb@vger.kernel.org, Y2038 , linux-kernel@vger.kernel.org, Felipe Balbi Subject: Re: [PATCH V2] dummy_hcd: replace timeval with timespec64 Date: Thu, 17 Sep 2015 10:12:48 +0200 Message-ID: <1527029.ps0FmI1B3T@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org> References: <2640620.MF43KccxAS@wuerfel> <1442459389-11171-1-git-send-email-pingbo.wen@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:2Y28D5VsUa9Y1dF+nyPJqeyh4+3iayZ9YPWq3Yhl4U4kJwmaoQp n+aquMzQkZC6nEuTm0VczzLJ7DqCY47ThPDgkm0AlWNs9Jwf3LOEZG0MOBXbKevTBsl4rw5 g0gwUMWnAHBHKfi+VPAeunl1OuDnavQdZTChKezjXEYG6jF2l2mSbxSnFF2ib8Zhyq0SEnD ZA6iywVGrBPCMAI4GNIrg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0fcGPdQV/mM=:ixRmSNRBjDI5/uTOssNXgz gJ/VSulguXxJABd3tE5vcpDxora+m7kOt7lHQGZFWQD/Jx8JhBUHXRwvipbV2GCzQMSterRSd htc88/vFGVrzylKK+kXH8Rc+LyM2aoHX6t0zat17NxygVa8oOAtNISa4noWsEO7g3y7r9NuSz 6u/sJPknA2G3KzRNIwNZZ8B0gV5vQK9Qw8wsQqdfj+eD72JqfCMoYZtkrZp98o6wK9kgjF36o D/DlFBeF0t2LrjRepIhtJciq7qVaab0XFniFShAmr9+2Lqu0WrQuUA2YkfBfceZwLoa9k44vZ rLnHduVjmKmyHv1Nwy8MiUk+j7NARiIn9FbGglldwTHJtJlYWFW2h1vDXJvhSP4tOImixI/H4 Bij4C84WuX+wTCr6VTJz6Ddp7TsPTnj8De/tYWl/rn7zTmorVvxTxp0p14+pUQ5GEr7UXkXrB vmLsspTOfQAh/4UWrffbYnD+LHCE+CTB6rXrCsmnl/ajVQNKYsPIJ933rQDuroB4F+/tvvF6F bwQmqIsX7WmlySOoI3djLYI3OneODX/l3KiVrYYLosSv4Xm7lPk2m3KAHk9a8AHJf/hvsmPSm 3JORoAUMXxPeAAVwrq3J12LS53FlJpm+MStGiqVSJZN2lnptLolfT3SHE42pl7aiOPT7WF/FX vjIn0LutVJRteekKcqvhdSNGv4UKJ9oX95Ov/fF1UVVAcxa30fKzfqnjjF9IDer9hLY6gqbyh kUwl19YJfQEmruvb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 17 September 2015 11:09:49 WEN Pingbo wrote: > The millisecond of the last second will be normal if tv_sec is > overflowed. But for y2038 consistency and demonstration purpose, > and avoiding further risks, we need to remove 'timeval' in this > driver, to avoid similair problems. > > V2 Updates: > - using monotonic time here by replacing getnstimeofday() with > ktime_get_ts64(), to avoid leap second issues. The frame time in USB > is always 1ms, no matter what speed, so ktime_get_ts64() have enough > resolution to cover this. > - using NSEC_PER_MSEC instead of hard code. > > Signed-off-by: Pingbo Wen > Cc: Y2038 > Cc: linux-kernel@vger.kernel.org > Cc: Arnd Bergmann > Cc: Felipe Balbi > Signed-off-by: WEN Pingbo > The patch looks good to me now, Reviewed-by: Arnd Bergmann Regarding the changelog, I notice you have a duplicate Signed-off-by line, one of the two should be removed. Also, The "V2 update" portion should be split into the part that you want in the changelog, without the '-' bullet points (in this case, the explanation for monontonic time), and the purely informational part that makes sense for the review but not for the git history (what changes were done against previous versions of the patch), which should go below the '---' line under the Signed-off-by chain, so it gets removed when imported to git. If Felipe decides to do these changes himself when he applies the patch, that's fine, otherwise please send the patch again as 'V3' tomorrow. Arnd