From: Roger Quadros <rogerq@ti.com>
To: <balbi@kernel.org>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH 1/2] usb: dwc3: of-simple: Don't fail if no clock entries
Date: Mon, 28 May 2018 17:36:13 +0300 [thread overview]
Message-ID: <1527518174-27860-1-git-send-email-rogerq@ti.com> (raw)
of_count_phandle_with_args() returns -ENOENT (-2) if
there are no clock entries. Don't fail in such a case.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/usb/dwc3/dwc3-of-simple.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index cb2ee96..e98d221 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -36,11 +36,11 @@ static int dwc3_of_simple_clk_init(struct dwc3_of_simple *simple, int count)
struct device_node *np = dev->of_node;
int i;
- simple->num_clocks = count;
-
- if (!count)
+ if (count <= 0)
return 0;
+ simple->num_clocks = count;
+
simple->clks = devm_kcalloc(dev, simple->num_clocks,
sizeof(struct clk *), GFP_KERNEL);
if (!simple->clks)
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next reply other threads:[~2018-05-28 14:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-28 14:36 Roger Quadros [this message]
2018-05-28 14:36 ` [PATCH 2/2] usb: dwc3: of_simple: don't call pm_runtime_set_active() Roger Quadros
2018-05-28 15:41 ` Johan Hovold
2018-05-31 13:25 ` Johan Hovold
2018-05-31 14:07 ` Alan Stern
2018-05-31 14:37 ` Johan Hovold
2018-05-30 12:31 ` Felipe Balbi
2018-05-31 7:23 ` Roger Quadros
2018-05-31 7:59 ` Felipe Balbi
2018-06-13 11:15 ` Roger Quadros
2018-06-14 7:57 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1527518174-27860-1-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®