From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754794AbeEaLqf (ORCPT ); Thu, 31 May 2018 07:46:35 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:46970 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754522AbeEaLqe (ORCPT ); Thu, 31 May 2018 07:46:34 -0400 From: Wei Yongjun To: Alasdair Kergon , Mike Snitzer , Mikulas Patocka CC: Wei Yongjun , , , Subject: [PATCH -next] dm writecache: fix return value check in writecache_ctr() Date: Thu, 31 May 2018 11:53:15 +0000 Message-ID: <1527767595-76082-1-git-send-email-weiyongjun1@huawei.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function dm_io_client_create() and dm_kcopyd_client_create() return ERR_PTR() not NULL in case of error. The NULL test in the return value check should be replaced with IS_ERR() Fixes: 2105231db61b ("dm: add writecache target") Signed-off-by: Wei Yongjun --- drivers/md/dm-writecache.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 844c4fb..0b2b436 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -1872,9 +1872,10 @@ static int writecache_ctr(struct dm_target *ti, unsigned argc, char **argv) } wc->dm_io = dm_io_client_create(); - if (!wc->dm_io) { - r = -ENOMEM; + if (IS_ERR(wc->dm_io)) { + r = PTR_ERR(wc->dm_io); ti->error = "Unable to allocate dm-io client"; + wc->dm_io = NULL; goto bad; } @@ -2096,9 +2097,10 @@ static int writecache_ctr(struct dm_target *ti, unsigned argc, char **argv) } wc->dm_kcopyd = dm_kcopyd_client_create(&dm_kcopyd_throttle); - if (!wc->dm_kcopyd) { - r = -ENOMEM; + if (IS_ERR(wc->dm_kcopyd)) { + r = PTR_ERR(wc->dm_kcopyd); ti->error = "Unable to allocate dm-kcopyd client"; + wc->dm_kcopyd = NULL; goto bad; }