From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754081AbeEaTHF convert rfc822-to-8bit (ORCPT ); Thu, 31 May 2018 15:07:05 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34052 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754003AbeEaTHD (ORCPT ); Thu, 31 May 2018 15:07:03 -0400 Date: Fri, 01 Jun 2018 00:36:54 +0530 From: "Naveen N. Rao" Subject: Re: [PATCH 2/2] powerpc: Add support for function error injection To: Josef Bacik , Masami Hiramatsu , Ingo Molnar , Michael Ellerman Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org References: <5ad23690185a90a887514d702ecb45783090d7c0.1527596631.git.naveen.n.rao@linux.vnet.ibm.com> <87h8mozajv.fsf@concordia.ellerman.id.au> <1527761352.z5jz8jg2d5.naveen@linux.ibm.com> <87zi0fyktj.fsf@concordia.ellerman.id.au> In-Reply-To: <87zi0fyktj.fsf@concordia.ellerman.id.au> User-Agent: astroid/0.11.1 (https://github.com/astroidmail/astroid) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 18053119-4275-0000-0000-000002885F55 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18053119-4276-0000-0000-0000378F6572 Message-Id: <1527793526.g9zv2oo8k4.naveen@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-05-31_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=940 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1805310211 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michael Ellerman wrote: > "Naveen N. Rao" writes: > >> Michael Ellerman wrote: >>> "Naveen N. Rao" writes: >>>> ... >>> >>> A change log is always nice even if it's short :) >> >> I tried, but really couldn't come up with anything more to write. I'll >> try harder for v2 :) > > Yeah true. > > You could just say "All that's required is to define x and y and select > the Kconfig symbol". Ok, sure. > >>> This looks fine to me, it's probably easiest if it goes in via tip along >>> with patch 1. >>> >>> Acked-by: Michael Ellerman >> >> Thanks for the review. I'll base v2 on -tip > > I guess if it doesn't already apply to tip you should rebase it. You've > probably missed 4.18 anyway. Oh ok. I just tried and it seems to apply just fine. I'll post v2 after giving this a quick test. - Naveen