From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 2/3] PM / sleep: Mark suspend/hibernation start and finish
Date: Wed, 19 Jul 2017 02:39:58 +0200 [thread overview]
Message-ID: <1528829.lXeqX43PVF@aspire.rjw.lan> (raw)
In-Reply-To: <2539550.y54cRb749c@aspire.rjw.lan>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Regardless of whether or not debug messages from the core system
suspend/hibernation code are enabled, it is useful to know when
system-wide transitions start and finish (or fail), so print "info"
messages at these points.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
kernel/power/hibernate.c | 8 ++++++++
kernel/power/suspend.c | 4 ++++
2 files changed, 12 insertions(+)
Index: linux-pm/kernel/power/hibernate.c
===================================================================
--- linux-pm.orig/kernel/power/hibernate.c
+++ linux-pm/kernel/power/hibernate.c
@@ -692,6 +692,7 @@ int hibernate(void)
goto Unlock;
}
+ pr_info("Starting hibernation\n");
pm_prepare_console();
error = __pm_notifier_call_chain(PM_HIBERNATION_PREPARE, -1, &nr_calls);
if (error) {
@@ -762,6 +763,11 @@ int hibernate(void)
atomic_inc(&snapshot_device_available);
Unlock:
unlock_system_sleep();
+ if (error)
+ pr_info("Hibernation failed (%d)\n", error);
+ else
+ pr_info("System resume complete\n");
+
return error;
}
@@ -868,6 +874,7 @@ static int software_resume(void)
goto Unlock;
}
+ pr_info("Starting resume from hibernation\n");
pm_prepare_console();
error = __pm_notifier_call_chain(PM_RESTORE_PREPARE, -1, &nr_calls);
if (error) {
@@ -884,6 +891,7 @@ static int software_resume(void)
Finish:
__pm_notifier_call_chain(PM_POST_RESTORE, nr_calls, NULL);
pm_restore_console();
+ pr_info("Resume from hibernation failed (%d)\n", error);
atomic_inc(&snapshot_device_available);
/* For success case, the suspend path will release the lock */
Unlock:
Index: linux-pm/kernel/power/suspend.c
===================================================================
--- linux-pm.orig/kernel/power/suspend.c
+++ linux-pm/kernel/power/suspend.c
@@ -579,12 +579,16 @@ int pm_suspend(suspend_state_t state)
if (state <= PM_SUSPEND_ON || state >= PM_SUSPEND_MAX)
return -EINVAL;
+ pr_info("PM: Starting system suspend (%s)\n", pm_states[state]);
error = enter_state(state);
if (error) {
suspend_stats.fail++;
dpm_save_failed_errno(error);
+ pr_info("PM: System suspend (%s) failed (%d)\n",
+ pm_states[state], error);
} else {
suspend_stats.success++;
+ pr_info("PM: System resume complete\n");
}
return error;
}
next prev parent reply other threads:[~2017-07-19 0:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 0:37 [PATCH 0/3] PM / sleep: Avoid filling up kernel log buffer with debug messages Rafael J. Wysocki
2017-07-19 0:38 ` [PATCH 1/3] PM / sleep: Do not print debug messages by default Rafael J. Wysocki
2017-07-19 0:39 ` Rafael J. Wysocki [this message]
2017-07-20 1:38 ` [PATCH v2 2/3] PM / sleep: Mark suspend/hibernation start and finish Rafael J. Wysocki
2017-07-20 17:49 ` Mark Salyzyn
2017-07-20 21:05 ` Rafael J. Wysocki
2017-07-19 0:42 ` [PATCH 3/3] PM / timekeeping: Print debug messages when requested Rafael J. Wysocki
2017-07-20 21:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1528829.lXeqX43PVF@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®