mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Greentime Hu <green.hu@gmail.com>
Cc: Vincent Chen <deanbo422@gmail.com>,
	linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
	Matt Redfearn <matt.redfearn@mips.com>,
	James Hogan <jhogan@kernel.org>,
	Palmer Dabbelt <palmer@sifive.com>
Subject: [PATCH] nds32: Fix build error caused by incomplete configuration flag rename
Date: Wed, 13 Jun 2018 12:43:52 -0700	[thread overview]
Message-ID: <1528919032-4874-1-git-send-email-linux@roeck-us.net> (raw)

GENERIC_ASHLDI3, GENERIC_ASHRDI3, and GENERIC_LSHRDI3 were renamed to
GENERIC_LIB_ASHLDI3, GENERIC_LIB_ASHRDI3, and GENERIC_LIB_LSHRDI3
without making the matching changes in arch/nds32. This results in
the following build errors.

nds32le-linux-ld: kernel/time/timekeeping.o:
	in function `timekeeping_init':
timekeeping.c:(.init.text+0x140):
	undefined reference to `__ashldi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x144):
	undefined reference to `__ashldi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x17e):
	undefined reference to `__lshrdi3'
nds32le-linux-ld: timekeeping.c:(.init.text+0x182):
	undefined reference to `__lshrdi3'
nds32le-linux-ld: drivers/clocksource/mmio.o:
	in function `clocksource_mmio_init':
mmio.c:(.init.text+0x54):
	undefined reference to `__lshrdi3'
nds32le-linux-ld: mmio.c:(.init.text+0x58):
	undefined reference to `__lshrdi3'

Fixes: e3d5980568f ("lib: Rename compiler intrinsic selects to GENERIC_LIB_*")
Cc: Matt Redfearn <matt.redfearn@mips.com>
Cc: James Hogan <jhogan@kernel.org>
Cc: Palmer Dabbelt <palmer@sifive.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 arch/nds32/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/nds32/Kconfig b/arch/nds32/Kconfig
index 6aed974276d8..3a68d9494035 100644
--- a/arch/nds32/Kconfig
+++ b/arch/nds32/Kconfig
@@ -12,9 +12,9 @@ config NDS32
 	select CLONE_BACKWARDS
 	select COMMON_CLK
 	select DMA_NONCOHERENT_OPS
-	select GENERIC_ASHLDI3
-	select GENERIC_ASHRDI3
-	select GENERIC_LSHRDI3
+	select GENERIC_LIB_ASHLDI3
+	select GENERIC_LIB_ASHRDI3
+	select GENERIC_LIB_LSHRDI3
 	select GENERIC_CMPDI2
 	select GENERIC_MULDI3
 	select GENERIC_UCMPDI2
-- 
2.7.4


             reply	other threads:[~2018-06-13 19:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13 19:43 Guenter Roeck [this message]
2018-06-13 21:06 ` James Hogan
2018-06-13 21:28   ` Guenter Roeck
2018-06-13 21:55     ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1528919032-4874-1-git-send-email-linux@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=deanbo422@gmail.com \
    --cc=green.hu@gmail.com \
    --cc=jhogan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.redfearn@mips.com \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome