From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, shawnguo@kernel.org, kernel@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com,
laurent.pinchart@ideasonboard.com, dan.scally@ideasonboard.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] dt-bindings: arm: fsl: fix DEBIX binding
Date: Mon, 17 Jul 2023 21:51:13 +0200 [thread overview]
Message-ID: <152926f2-3c53-d788-9443-486fb5ed8024@linaro.org> (raw)
In-Reply-To: <20230717171244.jdqwn5l7tiugxeyo@pengutronix.de>
On 17/07/2023 19:12, Marco Felsch wrote:
> On 23-07-17, Krzysztof Kozlowski wrote:
>> On 17/07/2023 18:51, Marco Felsch wrote:
>>> The current imx8mp-debix-model-a.dts uses all three compatibles. Fix the
>>> corresponding bindings by adding an own entry for it. Mark
>>> polyhex,imx8mp-debix as deprecated but keep it within the dts file since
>>> we already have a user for it [1].
>>>
>>> [1] https://elixir.bootlin.com/barebox/v2023.07.1/source/arch/arm/ \
>>> boards/polyhex-debix/board.c#L38
Don't wrap links, they are not clickable.
>>>
>>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>>> ---
>>> Changelog:
>>>
>>> v2:
>>> - deprecate polyhex,imx8mp-debix
>>>
>>> Documentation/devicetree/bindings/arm/fsl.yaml | 10 ++++++++--
>>> 1 file changed, 8 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 15d4110840654..b29974e3c30b3 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -1019,8 +1019,6 @@ properties:
>>> - dmo,imx8mp-data-modul-edm-sbc # i.MX8MP eDM SBC
>>> - fsl,imx8mp-evk # i.MX8MP EVK Board
>>> - gateworks,imx8mp-gw74xx # i.MX8MP Gateworks Board
>>> - - polyhex,imx8mp-debix # Polyhex Debix boards
>>> - - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules
>>> - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT
>>> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules
>>> @@ -1054,6 +1052,14 @@ properties:
>>> - const: phytec,imx8mp-phycore-som # phyCORE-i.MX8MP SoM
>>> - const: fsl,imx8mp
>>>
>>> + - description: Polyhex DEBIX i.MX8MP based SBCs
>>> + items:
>>> + - enum:
>>> + - polyhex,imx8mp-debix-model-a # Polyhex Debix Model A Board
>>> + - const: polyhex,imx8mp-debix # Polyhex Debix boards
>>
>> I cannot find patches which add new compatible to the binding and which
>> fix the DTS. :/
>
> Please see my commit message, we can't remove the compatible since we
> already have one user of this compatible.
Indeed. I wonder then what is the goal of deprecating this compatible
and what is the plan for dealing with it? There is no cover letter which
would point me to it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 19:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 16:51 [PATCH v2 1/4] arm64: dts: imx8mp-debix: remove unused fec pinctrl node Marco Felsch
2023-07-17 16:51 ` [PATCH v2 2/4] dt-bindings: arm: fsl: fix DEBIX binding Marco Felsch
2023-07-17 16:59 ` Krzysztof Kozlowski
2023-07-17 17:14 ` Marco Felsch
2023-07-17 19:45 ` Krzysztof Kozlowski
2023-07-17 17:00 ` Krzysztof Kozlowski
2023-07-17 17:12 ` Marco Felsch
2023-07-17 19:51 ` Krzysztof Kozlowski [this message]
2023-07-17 17:17 ` Ahmad Fatoum
2023-07-17 17:24 ` Marco Felsch
2023-07-17 17:38 ` Ahmad Fatoum
2023-07-19 9:34 ` Marco Felsch
2023-07-17 16:51 ` [PATCH v2 3/4] dt-bindings: arm: Add Polyhex DEBIX SOM A based boards Marco Felsch
2023-07-25 12:54 ` Laurent Pinchart
2023-07-17 16:51 ` [PATCH v2 4/4] arm64: dts: freescale: Add DEBIX SOM A and SOM A I/O Board support Marco Felsch
2023-07-18 14:06 ` Fabio Estevam
2023-07-19 8:16 ` Shawn Guo
2023-07-19 9:18 ` Marco Felsch
2023-07-25 13:26 ` Laurent Pinchart
2023-07-31 8:51 ` Marco Felsch
2023-07-25 12:51 ` [PATCH v2 1/4] arm64: dts: imx8mp-debix: remove unused fec pinctrl node Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152926f2-3c53-d788-9443-486fb5ed8024@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®