From: Leo Yan <leo.yan@linaro.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Mike Leach <mike.leach@linaro.org>,
Robert Walker <robert.walker@arm.com>,
Kim Phillips <kim.phillips@arm.com>
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [PATCH v1 2/6] perf cs-etm: Bail out immediately for instruction sample failure
Date: Mon, 18 Jun 2018 13:09:55 +0800 [thread overview]
Message-ID: <1529298599-3876-3-git-send-email-leo.yan@linaro.org> (raw)
In-Reply-To: <1529298599-3876-1-git-send-email-leo.yan@linaro.org>
If the instruction sample failure has happened, it isn't necessary to
execute to the end of the function cs_etm__flush(). This commit is to
bail out immediately and return the error code.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
tools/perf/util/cs-etm.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c
index 822ba91..8b2c099 100644
--- a/tools/perf/util/cs-etm.c
+++ b/tools/perf/util/cs-etm.c
@@ -939,6 +939,9 @@ static int cs_etm__flush(struct cs_etm_queue *etmq)
err = cs_etm__synth_instruction_sample(
etmq, addr,
etmq->period_instructions);
+ if (err)
+ return err;
+
etmq->period_instructions = 0;
/*
--
2.7.4
next prev parent reply other threads:[~2018-06-18 5:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 5:09 [PATCH v1 0/6] perf cs-etm: Fix tracing packet handling and minor refactoring Leo Yan
2018-06-18 5:09 ` [PATCH v1 1/6] perf cs-etm: Introduce invalid address macro Leo Yan
2018-07-25 20:40 ` [tip:perf/core] " tip-bot for Leo Yan
2018-06-18 5:09 ` Leo Yan [this message]
2018-07-25 20:41 ` [tip:perf/core] perf cs-etm: Bail out immediately for instruction sample failure tip-bot for Leo Yan
2018-06-18 5:09 ` [PATCH v1 3/6] perf cs-etm: Fix start tracing packet handling Leo Yan
2018-06-18 5:09 ` [PATCH v1 4/6] perf cs-etm: Support dummy address value for CS_ETM_TRACE_ON packet Leo Yan
2018-06-18 5:09 ` [PATCH v1 5/6] perf cs-etm: Generate branch sample when receiving a " Leo Yan
2018-06-18 5:09 ` [PATCH v1 6/6] perf cs-etm: Generate branch sample for " Leo Yan
2018-06-19 17:46 ` [PATCH v1 0/6] perf cs-etm: Fix tracing packet handling and minor refactoring Mathieu Poirier
2018-06-19 18:19 ` Arnaldo Carvalho de Melo
2018-07-02 2:35 ` leo.yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529298599-3876-3-git-send-email-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kim.phillips@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=robert.walker@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®