From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f226.google.com (mail-pf1-f226.google.com [209.85.210.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC70A30BB95 for ; Wed, 17 Dec 2025 21:55:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.226 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766008534; cv=none; b=Qmcq3RUyKC7qAgSSKIg9TnwSpPbSpjf548Mp5667J6u6mn1vb+5PanrkVJ0kTewZz8cqruTdLyOwOEV8fO70a0Oe0eT8tJ1xGjO7dQDmI9pzmAe97Mxhr20lVqPkIv428+1l57cbeBlIjetgdxNgjAXm5kzkc4qQAekWMCKktIM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766008534; c=relaxed/simple; bh=8T8W96eTJCxhSN+CFeu2gxRyFM7jAiDwsLt+4C/rw6M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m7Ua02M90X8her5WEiwOZWNCI4cfe9ppm3Ym0HjcK++ldf39n46Lbn6+EHuGcfKwgVYL7yNJXk3PD9pz1NwnZty327tgZHhxI1e3sS9Nlla7SlKWEFyfIXwB9Kq/aak5d6YLPGgtxN3EvxSE57vmvZRFf5pC8Kai1g9HJlkr+5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=bZo4Z866; arc=none smtp.client-ip=209.85.210.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="bZo4Z866" Received: by mail-pf1-f226.google.com with SMTP id d2e1a72fcca58-7aab7623f42so7061b3a.2 for ; Wed, 17 Dec 2025 13:55:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766008532; x=1766613332; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aveKwRCblTq+fpsGsYnFrsRpm0V+YPvEgKy0+wbVdM0=; b=se2+ppYYoP5mQ75BejAvIApjbhIee78vw4x8APQev8duRi/bh25IHVArC+k8RP5nTI gcZiPA4xEWUMs76hsu6tAbdL3aHiXKw0K3NyHF9NhSzbANu7RM4xv5B0j0UteGy6MSWx AwFzImPmMMNqLJu3cuNMsoViSz4NE9IPdSRtnmZXE5U6aoTINc6Gp6mB0YEaOzvI4uSM 5/t+xgEhF//9oA7dXM5/1GroyGXTZeWNB0pJ8z2wNwJwb3kkyJdKLGYk9x+EWPLjDy4B GB6EyDWmNHE/zHclL3aduVf10gHPvnhWZmjiyO5H+uEKeYT7AmZXVgE3kAf+HjLfVxvI KuUA== X-Forwarded-Encrypted: i=1; AJvYcCXVDJMJ3mOCFPohjC8ap39JKO+tToBIwIZ26baUUL9V8Gkaj6bOCHGt53YTHU9wWzHfa4DD9NceMdfBpCA=@vger.kernel.org X-Gm-Message-State: AOJu0YzFDthnICAPSI6j8elNrZ4d6A/Dg3XvE/seg2D2cjEX5hYdx/IP YcUgjP5XaR5Sieo4i9diA/ma11Mcpyq2Phl+j13yvYsjh0/vmuEx+3rBglBEpPnXsVf2vPlJDdp WJZ9HumXDKiHOUxpcxu70tQUNSriFZ/PSjFFwRTrwWqE5WZGHY8kZUXmQ3dZr6Ekf1HVBNM2+uW JzTWFLg9eQMgezEI8ZSZ3i3+m1YXLw//yUyg7C36Bi2Cp50ImwsLqmoQ/wbpuMmgQveCpbzI3vK nHv2cY7Xw8X107XsA2IN+WN X-Gm-Gg: AY/fxX4Xk4pZNA+/7NsKhLHvX3tmzSqq/hvwHnvqhLvyNBUnf8ttc8gyedG98VJovgQ tIFjwKLAxEeu/R1Yd48muCOc8gw4e3BB0IDsRZoaRtE9wCtv6nusCg9xcsXX9kigTqHDWC7RmtR bnaItchv4Xzy4bE46sGJ/hEovvsamH1vXEZaXr2+TrOFlqol7qljstwyeDTKJfTTEzdDvpsNCN3 KuzTgiKfeBo6IIs9d9xz4NgSOQr0Axfa3AsU5m978tdwXo4bL+IhaYBpX1bfi87tOdeufD3Dz1n yGsEgCWhmBthNGZKLIewM97tHtBzuH0k/ZIVdNnViEl2VpeyV4Mt/fwCYZL5OVA5WWaFqatMI/W nddWK6xhjnJZsdJ1j4Q/7xxkExsyBqXKgLsNSs7VMr7dpY4ccWToreZC5NV7TvFivOp51rJSXK9 49mnrP7nwqbGDVHvfe/oS7DPztjzJ2BxqCEVv5L7wxW/PVLRW81A== X-Google-Smtp-Source: AGHT+IGSGqjHiG5kQAYGj5KIwLlIZPq+ozmbhUtZRYXtE4L5fDLw0JGR7BOXLFMONP5VF+dYj8VSBU9Gdahr X-Received: by 2002:a05:6a00:4c8f:b0:77c:6621:6168 with SMTP id d2e1a72fcca58-7f6683f00e6mr17750381b3a.30.1766008532025; Wed, 17 Dec 2025 13:55:32 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-19.dlp.protect.broadcom.com. [144.49.247.19]) by smtp-relay.gmail.com with ESMTPS id d2e1a72fcca58-7fe13a9d32csm66786b3a.5.2025.12.17.13.55.31 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Dec 2025 13:55:32 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4f1dea13d34so113671851cf.1 for ; Wed, 17 Dec 2025 13:55:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1766008531; x=1766613331; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=aveKwRCblTq+fpsGsYnFrsRpm0V+YPvEgKy0+wbVdM0=; b=bZo4Z866EmsCgynSXObNzVW6Mjpu40GnapnJISkpN2bRxbxQ0A26YAZJE25I1CmYmx iGRJJHClJQcIgUGuT4oMIGSQEFuECbSscLvJscLJ1Z23v0ct73/LFCVxNOhQn1rcUQ/I 7GvNkFjlklxF6Qufw97UoHI+dWZCcMEL535OU= X-Forwarded-Encrypted: i=1; AJvYcCUfEAoT7f3D8UXYYpHgIqwMCYqlwcv2PtDBN9M2JHn8jhoLjXmqi8kp/y/DqCzjfBMno906PLcJT8VCad0=@vger.kernel.org X-Received: by 2002:a05:622a:a11:b0:4eb:9df6:5d6f with SMTP id d75a77b69052e-4f1d065088amr271829971cf.74.1766008530719; Wed, 17 Dec 2025 13:55:30 -0800 (PST) X-Received: by 2002:a05:622a:a11:b0:4eb:9df6:5d6f with SMTP id d75a77b69052e-4f1d065088amr271829821cf.74.1766008530331; Wed, 17 Dec 2025 13:55:30 -0800 (PST) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4f35fca94e9sm3129351cf.11.2025.12.17.13.55.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Dec 2025 13:55:29 -0800 (PST) Message-ID: <152b1e05-b330-4869-b69c-4d39c91a64d6@broadcom.com> Date: Wed, 17 Dec 2025 13:55:27 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net: dsa: b53: skip multicast entries for fdb_dump() To: Jonas Gorski , Florian Fainelli , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251217205756.172123-1-jonas.gorski@gmail.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20251217205756.172123-1-jonas.gorski@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 12/17/25 12:57, Jonas Gorski wrote: > port_fdb_dump() is supposed to only add fdb entries, but we iterate over > the full ARL table, which also inludes multicast entries. > > So check if the entry is a multicast entry before passing it on to the > callback(). > > Additionally, the port of those entries is a bitmask, not a port number, > so any included entries would have even be for the wrong port. > > Fixes: 1da6df85c6fb ("net: dsa: b53: Implement ARL add/del/dump operations") > Signed-off-by: Jonas Gorski Reviewed-by: Florian Fainelli -- Florian