From: Dave Hansen <dave.hansen@intel.com>
To: "Li, Aubrey" <aubrey.li@linux.intel.com>,
Aubrey Li <aubrey.li@intel.com>,
tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org,
hpa@zytor.com
Cc: ak@linux.intel.com, tim.c.chen@linux.intel.com,
arjan@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks
Date: Tue, 11 Dec 2018 16:39:48 -0800 [thread overview]
Message-ID: <152d1ac3-21ed-2d59-1939-6448a854c34e@intel.com> (raw)
In-Reply-To: <f142bab7-5ede-b17c-f0e0-f1ab0acb44cd@linux.intel.com>
On 12/11/18 4:34 PM, Li, Aubrey wrote:
>> Is there a reason we shouldn't do:
>>
>> if (!cpu_feature_enabled(X86_FEATURE_AVX512F))
>> update_avx512_state(fpu);
>>
>> ?
>>
> Why _!_ ?
Sorry, got it backwards. I think I was considering having you do a
if (!cpu_feature_enabled(X86_FEATURE_AVX512F))
return;
inside of update_avx512_state(), but I got the state mixed up in my head.
You don't need the '!'.
next prev parent reply other threads:[~2018-12-12 0:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 0:24 Aubrey Li
2018-12-11 0:24 ` [PATCH v4 2/2] proc: add AVX-512 usage to /proc/pid/status Aubrey Li
2018-12-11 17:57 ` Tim Chen
2018-12-11 17:18 ` [PATCH v4 1/2] x86/fpu: track AVX-512 usage of tasks Dave Hansen
2018-12-11 17:52 ` Tim Chen
2018-12-11 17:53 ` Andi Kleen
2018-12-11 23:46 ` Li, Aubrey
2018-12-12 0:14 ` Arjan van de Ven
2018-12-12 0:59 ` Li, Aubrey
2018-12-12 1:06 ` Dave Hansen
2018-12-11 17:20 ` Dave Hansen
2018-12-12 0:34 ` Li, Aubrey
2018-12-12 0:39 ` Dave Hansen [this message]
2018-12-12 16:55 ` David Laight
2018-12-12 18:00 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=152d1ac3-21ed-2d59-1939-6448a854c34e@intel.com \
--to=dave.hansen@intel.com \
--cc=ak@linux.intel.com \
--cc=arjan@linux.intel.com \
--cc=aubrey.li@intel.com \
--cc=aubrey.li@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®