From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752132AbdLETkh (ORCPT ); Tue, 5 Dec 2017 14:40:37 -0500 Received: from ale.deltatee.com ([207.54.116.67]:52594 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751944AbdLETkd (ORCPT ); Tue, 5 Dec 2017 14:40:33 -0500 To: Jon Mason Cc: linux-ntb , linux-kernel , Dave Jiang , Allen Hubbe , Kelvin Cao References: <20171129175530.31032-1-logang@deltatee.com> <20171129175530.31032-6-logang@deltatee.com> From: Logan Gunthorpe Message-ID: <152d55bb-be8f-2699-f13c-cdc1d59e460e@deltatee.com> Date: Tue, 5 Dec 2017 12:40:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: kelvin.cao@microsemi.com, Allen.Hubbe@emc.com, dave.jiang@intel.com, linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, jdmason@kudzu.us X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH 5/7] ntb_hw_switchtec: Expand PFF CSR registers X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/12/17 12:12 PM, Jon Mason wrote: > It sucks that we don't already have a struct for PCI config space we > can reuse here. If you find the time, it would be good to add in the > future to reduce duplicate code here and in the PCI core. However, > this patch is fine without it. I agree. And believe me I looked for one. I'm not sure if it makes sense to add it to general code at this time when I'm the only user. Logan