From: Guenter Roeck <linux@roeck-us.net>
To: "David S . Miller" <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>
Subject: [PATCH] sparc32: cacheflush_32: Declare struct page
Date: Fri, 29 Jun 2018 21:45:10 -0700 [thread overview]
Message-ID: <1530333910-31209-1-git-send-email-linux@roeck-us.net> (raw)
Building allmodconfig images for sparc32 generates warnings such as
arch/sparc/include/asm/cacheflush_32.h:40:37: warning:
'struct page' declared inside parameter list
This results in odd warnings such as
arch/sparc/include/asm/cacheflush_32.h:40:6: note:
expected 'struct page *' but argument is of type 'struct page *'
With recent compilers (gcc 5.5.0 and later), this warning turns into
a build error when compiling drivers/staging/media/omap4iss/iss_video.c.
./include/linux/highmem.h: In function 'copy_user_highpage':
./include/linux/highmem.h:233:36: error:
passing argument 1 of 'sparc_flush_page_to_ram'
from incompatible pointer type
Declare struct page to fix the problem.
Fixes: 84fc727ed49c ("media: omap4iss: make it build with COMPILE_TEST")
Cc: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/sparc/include/asm/cacheflush_32.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/sparc/include/asm/cacheflush_32.h b/arch/sparc/include/asm/cacheflush_32.h
index fb66094a2c30..acb072c71e42 100644
--- a/arch/sparc/include/asm/cacheflush_32.h
+++ b/arch/sparc/include/asm/cacheflush_32.h
@@ -4,6 +4,8 @@
#include <asm/cachetlb_32.h>
+struct page;
+
#define flush_cache_all() \
sparc32_cachetlb_ops->cache_all()
#define flush_cache_mm(mm) \
--
2.7.4
reply other threads:[~2018-06-30 4:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530333910-31209-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®