From: Nicholas Mc Guire <hofrat@osadl.org>
To: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicholas Mc Guire <hofrat@osadl.org>
Subject: [PATCH 1/2] drivers: clk: st: warn on iomap failure
Date: Sun, 15 Jul 2018 12:18:23 +0200 [thread overview]
Message-ID: <1531649904-6072-1-git-send-email-hofrat@osadl.org> (raw)
While the return value of clkgen_get_register_base() is being checked
at the call site, there is no indication of failure cause thus making
diagnosis of the issues hard. The WARN_ON() allows to determine the
cause of failure.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
---
Problem found by an experimental coccinelle script
Patch was compile tested with: multi_v7_defconfig (implies
CONFIG_ARCH_STI=y)
Patch is against 4.18-rc4 (localversion-next is next-20180713)
drivers/clk/st/clkgen-pll.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c
index cbb5184..aeb30ab 100644
--- a/drivers/clk/st/clkgen-pll.c
+++ b/drivers/clk/st/clkgen-pll.c
@@ -647,6 +647,7 @@ static void __iomem * __init clkgen_get_register_base(
return NULL;
reg = of_iomap(pnode, 0);
+ WARN_ON(!reg);
of_node_put(pnode);
return reg;
--
2.1.4
next reply other threads:[~2018-07-15 10:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 10:18 Nicholas Mc Guire [this message]
2018-07-15 10:18 ` [PATCH 2/2] drivers: clk: st: address sparse warnings Nicholas Mc Guire
2018-07-25 20:40 ` Stephen Boyd
2018-07-26 5:50 ` Nicholas Mc Guire
2018-07-25 20:41 ` [PATCH 1/2] drivers: clk: st: warn on iomap failure Stephen Boyd
2018-07-26 5:43 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1531649904-6072-1-git-send-email-hofrat@osadl.org \
--to=hofrat@osadl.org \
--cc=keescook@chromium.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®