From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A77C9C6778A for ; Tue, 24 Jul 2018 16:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6250B20875 for ; Tue, 24 Jul 2018 16:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6250B20875 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388886AbeGXSAI (ORCPT ); Tue, 24 Jul 2018 14:00:08 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:57739 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388673AbeGXSAH (ORCPT ); Tue, 24 Jul 2018 14:00:07 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1fi0Y7-00007b-CE; Tue, 24 Jul 2018 18:52:35 +0200 Message-ID: <1532451152.32306.8.camel@pengutronix.de> Subject: Re: [PATCH v3 1/2] Revert "ARM: dts: imx7d: Invert legacy PCI irq mapping" From: Lucas Stach To: Leonard Crestez , Andrey Smirnov , Richard Zhu , Shawn Guo Cc: Anson Huang , Philipp Zabel , Bjorn Helgaas , Jingoo Han , Joao Pinto , Lorenzo Pieralisi , Fabio Estevam , Dong Aisheng , linux-imx@nxp.com, kernel@pengutronix.de, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 24 Jul 2018 18:52:32 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Dienstag, den 24.07.2018, 19:14 +0300 schrieb Leonard Crestez: > This reverts commit 1c86c9dd82f859b474474a7fee0d5195da2c9c1d. > > That commit followed the reference manual but unfortunately the imx7d > manual is incorrect. > > Tested with ath9k pcie card and confirmed internally. > > Signed-off-by: Leonard Crestez Acked-by: Lucas Stach > --- >  arch/arm/boot/dts/imx7d.dtsi | 12 ++++++++---- >  1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > index 7cbc2ffa4b3a..7234e8330a57 100644 > --- a/arch/arm/boot/dts/imx7d.dtsi > +++ b/arch/arm/boot/dts/imx7d.dtsi > @@ -124,14 +124,18 @@ > >   num-lanes = <1>; > >   interrupts = ; > >   interrupt-names = "msi"; > >   #interrupt-cells = <1>; > >   interrupt-map-mask = <0 0 0 0x7>; > > - interrupt-map = <0 0 0 1 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > > - <0 0 0 2 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > - <0 0 0 3 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > - <0 0 0 4 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>; > > + /* > > +  * Reference manual lists pci irqs incorrectly > > +  * Real hardware ordering is same as imx6: D+MSI, C, B, A > > +  */ > > + interrupt-map = <0 0 0 1 &intc GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > > + <0 0 0 2 &intc GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > + <0 0 0 3 &intc GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > + <0 0 0 4 &intc GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>; > >   clocks = <&clks IMX7D_PCIE_CTRL_ROOT_CLK>, > >    <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>, > >    <&clks IMX7D_PCIE_PHY_ROOT_CLK>; > >   clock-names = "pcie", "pcie_bus", "pcie_phy"; > >   assigned-clocks = <&clks IMX7D_PCIE_CTRL_ROOT_SRC>,